Extend preprocessor LLVM version checks to support LLVM 4.x #36742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
cc #36295 |
| @@ -45,7 +45,16 @@ | |||
| #include "llvm-c/ExecutionEngine.h" | |||
| #include "llvm-c/Object.h" | |||
|
|
|||
| #if LLVM_VERSION_MINOR >= 7 | |||
| #define LLVM_VERSION_GT_OR_EQ(major, minor) \ | |||
| LLVM_VERSION_MAJOR > (major) || LLVM_VERSION_MAJOR == (major) && LLVM_VERSION_MINOR >= (minor) | |||
There was a problem hiding this comment.
Could this entire clause also be wrapped in parens? (yay C macros)
same below as well
There was a problem hiding this comment.
Done!
Someone should really work on creating a replacement for this C language thing.
| @@ -45,7 +45,16 @@ | |||
| #include "llvm-c/ExecutionEngine.h" | |||
| #include "llvm-c/Object.h" | |||
|
|
|||
| #if LLVM_VERSION_MINOR >= 7 | |||
| #define LLVM_VERSION_GT_OR_EQ(major, minor) \ | |||
There was a problem hiding this comment.
Perhaps this could be LLVM_VERSION_GE?
Similar to ParialOrd::ge naming at least
This doesn't actually do anything for LLVM 4.x yet, but sets the stage.
c7341e5 to
e6e117c
Compare
|
@bors: r+ |
|
📌 Commit e6e117c has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 26, 2016
…richton Extend preprocessor LLVM version checks to support LLVM 4.x This doesn't actually do anything for LLVM 4.x yet, but sets the stage.
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 27, 2016
…richton Extend preprocessor LLVM version checks to support LLVM 4.x This doesn't actually do anything for LLVM 4.x yet, but sets the stage.
bors
added a commit
that referenced
this pull request
Sep 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't actually do anything for LLVM 4.x yet, but sets the stage.