-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update to "Getting Started" section #36563
Conversation
- Updated paragraphs and wording for clarity. - Renamed `helloworld.rs` to `myprogram.rs` to make it clearer that it's an unrelated example.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little nit to fix and then I r+.
in a *.rs* extension. If you’re using more than one word in your filename, use | ||
an underscore to separate them; for example, you'd use *hello_world.rs* rather | ||
than *helloworld.rs*. | ||
We need to create a source file for our Rust program. Rust files always end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra whitespace at the end of the line.
@bors: r+ rollup thank you! |
📌 Commit 0bd7ef0 has been approved by |
Docs: Update to "Getting Started" section I came across rust-lang#34523 and wanted to suggest a solution. See commit for details. It seemed like a good place to start contributing, let me know if I did anything wrong 😇
Docs: Update to "Getting Started" section I came across rust-lang#34523 and wanted to suggest a solution. See commit for details. It seemed like a good place to start contributing, let me know if I did anything wrong 😇
I came across #34523 and wanted to suggest a solution. See commit for details.
It seemed like a good place to start contributing, let me know if I did anything wrong 😇