configure: Check for valid Python on MinGW as well #34515
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I've fairly radically changed the MinGW instructions in the README here as well. I've attempted to start from a completely fresh MSYS2 install and follow these instructions to get a compiler bootstrapped, and they appear to be working. The biggest change is that we no longer request a custom download of the old 4.9.2 compilers, as it appears that whatever bug was there before is now gone. |
|
@bors r+ |
|
📌 Commit 2fb7694 has been approved by |
| diffutils \ | ||
| mingw-w64-x86_64-python2 \ | ||
| mingw-w64-x86_64-cmake \ | ||
| mingw-w64-x86_64-gcc |
There was a problem hiding this comment.
make is missing from the list
There was a problem hiding this comment.
Oh dear you are indeed correct!
2fb7694 to
8e867de
Compare
The LLVM build system is somewhat picky about which Python is used to build it as it's known to be incompatible with the default `python2` package that ships with MinGW. This was previously detected for MSVC builds but the logic was left out for MinGW by accident (now that we've switched to cmake builds for LLVM everywhere). This corrects the `./configure` check and also updates the `README.md` accordingly. Additionally, a number of instructions were updated to work with the most recent copy of MSYS2. Closes rust-lang#34489
8e867de to
cb74a58
Compare
|
@bors: r=brson |
|
📌 Commit cb74a58 has been approved by |
|
⌛ Testing commit cb74a58 with merge 80b0f0a... |
|
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
|
@bors: retry On Fri, Jul 1, 2016 at 5:42 AM, bors notifications@github.com wrote:
|
|
⌛ Testing commit cb74a58 with merge 1d149cf... |
|
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
|
@bors: retry On Fri, Jul 1, 2016 at 12:44 PM, bors notifications@github.com wrote:
|
configure: Check for valid Python on MinGW as well The LLVM build system is somewhat picky about which Python is used to build it as it's known to be incompatible with the default `python2` package that ships with MinGW. This was previously detected for MSVC builds but the logic was left out for MinGW by accident (now that we've switched to cmake builds for LLVM everywhere). This corrects the `./configure` check and also updates the `README.md` accordingly. Additionally, a number of instructions were updated to work with the most recent copy of MSYS2. Closes #28260 Closes #34489
The LLVM build system is somewhat picky about which Python is used to build it
as it's known to be incompatible with the default
python2package that shipswith MinGW. This was previously detected for MSVC builds but the logic was left
out for MinGW by accident (now that we've switched to cmake builds for LLVM
everywhere).
This corrects the
./configurecheck and also updates theREADME.mdaccordingly. Additionally, a number of instructions were updated to work with
the most recent copy of MSYS2.
Closes #28260
Closes #34489