Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions on how to build Rust with rustbuild #34504

Merged
merged 1 commit into from
Jul 3, 2016

Conversation

retep998
Copy link
Member

@retep998 retep998 commented Jun 27, 2016

This is a much simpler option for those on Windows who use msvc.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member

LGTM. Would you mind wrapping to 80 columns though?

@alexcrichton
Copy link
Member

In theory we only need python 2 (not 3) and there shouldn't be a need for the vcvars bit. Does it not work without either of these though? May be worth opening bugs on these two to ensure they get fixed at some point if so.

@hanna-kruppe
Copy link
Contributor

Having both Python 2 and Python 3 in PATH is nonsense, only one will get picked up (at least when you type python bootstrap.py — with the py launcher you could pull multi-version tricks but I sure hope the build system isn't that crazy).

@retep998
Copy link
Member Author

I'm running a build now to figure out whether python 3 and vcvars are strictly necessary.

@retep998
Copy link
Member Author

C:\msys64\home\Peter\rust [please-be-robust-already ≡]> python.exe .\src\bootstrap\bootstrap.py
thread '<main>' panicked at 'couldn't determine visual studio generator', C:\Users\Peter\.cargo\registry\src\github.com-1ecc6299db9ec823\cmake-0.1.17\src\lib.rs:382
stack backtrace:
   0:     0x7ff6f805c482 - std::rt::lang_start::h77a570d0150f3bb2
   1:     0x7ff6f805ba6d - std::rt::lang_start::h77a570d0150f3bb2
   2:     0x7ff6f8041775 - std::panicking::rust_panic_with_hook::h86decb25b2d9b2e0
   3:     0x7ff6f7fde944 - begin_panic<&str>
                        at C:\msys64\home\Peter\src\libstd\panicking.rs:328
   4:     0x7ff6f7fe15f9 - visual_studio_generator
                        at C:\msys64\home\Peter\rust\<std macros>:3
   5:     0x7ff6f7fd30cf - build
                        at C:\Users\Peter\.cargo\registry\src\github.com-1ecc6299db9ec823\cmake-0.1.17\src\lib.rs:276
   6:     0x7ff6f7efc997 - llvm
                        at C:\msys64\home\Peter\rust\src\bootstrap\build\native.rs:113
   7:     0x7ff6f7ee978b - build
                        at C:\msys64\home\Peter\rust\src\bootstrap\build\mod.rs:230
   8:     0x7ff6f7ee12ba - main
                        at C:\msys64\home\Peter\rust\src\bootstrap\main.rs:48
   9:     0x7ff6f805b46c - std::rt::lang_start::h77a570d0150f3bb2
  10:     0x7ff6f80616c1 - _rust_maybe_catch_panic
  11:     0x7ff6f805b1a4 - std::rt::lang_start::h77a570d0150f3bb2
  12:     0x7ff6f7eee9f9 - main
  13:     0x7ff6f8068bef - __scrt_common_main_seh
                        at f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:255
  14:     0x7ffe8ad78101 - BaseThreadInitThunk

Guess vcvars is strictly necessary.

@retep998
Copy link
Member Author

Updated PR with python 3 removed and adjusted things to fit in 80 columns.

@bors
Copy link
Contributor

bors commented Jul 2, 2016

☔ The latest upstream changes (presumably #34515) made this pull request unmergeable. Please resolve the merge conflicts.

This is a much simpler option for those on Windows who use msvc.

Signed-off-by: Peter Atashian <retep998@gmail.com>
@retep998
Copy link
Member Author

retep998 commented Jul 2, 2016

Rebased.

@alexcrichton
Copy link
Member

@bors: r+ be43c65

@arielb1
Copy link
Contributor

arielb1 commented Jul 2, 2016

@bors rollup

@bors
Copy link
Contributor

bors commented Jul 3, 2016

⌛ Testing commit be43c65 with merge 20183f4...

bors added a commit that referenced this pull request Jul 3, 2016
Instructions on how to build Rust with rustbuild

This is a much simpler option for those on Windows who use msvc.
@bors bors merged commit be43c65 into rust-lang:master Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants