-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions on how to build Rust with rustbuild #34504
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
LGTM. Would you mind wrapping to 80 columns though? |
In theory we only need python 2 (not 3) and there shouldn't be a need for the vcvars bit. Does it not work without either of these though? May be worth opening bugs on these two to ensure they get fixed at some point if so. |
Having both Python 2 and Python 3 in PATH is nonsense, only one will get picked up (at least when you type |
I'm running a build now to figure out whether python 3 and vcvars are strictly necessary. |
Guess vcvars is strictly necessary. |
Updated PR with python 3 removed and adjusted things to fit in 80 columns. |
☔ The latest upstream changes (presumably #34515) made this pull request unmergeable. Please resolve the merge conflicts. |
This is a much simpler option for those on Windows who use msvc. Signed-off-by: Peter Atashian <retep998@gmail.com>
Rebased. |
@bors rollup |
Instructions on how to build Rust with rustbuild This is a much simpler option for those on Windows who use msvc.
This is a much simpler option for those on Windows who use msvc.