-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
book: Clarify that trait or type must be in same crate as impl #31128
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors rollup |
Or something :p |
Since the chapter on traits comes before the one on crates, would it make sense to either quick-define crates or reference the chapter? |
Yes, we need a forward reference to the crates chapter. (and @bors will only listen to people with permission 😉 ) |
Of course. And done. |
@bors: r+ rollup thank you so much! |
📌 Commit a559577 has been approved by |
…y, r=steveklabnik
…y, r=steveklabnik
No description provided.