Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

book: Clarify that trait or type must be in same crate as impl #31128

Merged
merged 2 commits into from
Jan 23, 2016

Conversation

kamalmarhubi
Copy link
Contributor

No description provided.

@kamalmarhubi
Copy link
Contributor Author

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kamalmarhubi
Copy link
Contributor Author

@bors rollup

@kamalmarhubi
Copy link
Contributor Author

Or something :p

@kamalmarhubi
Copy link
Contributor Author

Since the chapter on traits comes before the one on crates, would it make sense to either quick-define crates or reference the chapter?

@steveklabnik
Copy link
Member

Yes, we need a forward reference to the crates chapter.

(and @bors will only listen to people with permission 😉 )

@kamalmarhubi
Copy link
Contributor Author

Of course.

And done.

@steveklabnik
Copy link
Member

@bors: r+ rollup

thank you so much!

@bors
Copy link
Contributor

bors commented Jan 22, 2016

📌 Commit a559577 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 23, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 23, 2016
bors added a commit that referenced this pull request Jan 23, 2016
@bors bors merged commit a559577 into rust-lang:master Jan 23, 2016
@kamalmarhubi kamalmarhubi deleted the book-trait-impl-clarify branch January 24, 2016 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants