Improve CStr::from_ptr example in docs #31019
Conversation
Documentation of `CStr::from_ptr` suggests using `str::from_utf8(slice.to_bytes()).unwrap()` to obtain a `&str` but `CStr` has `CStr::to_str` that does exactly that.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
⌛ Testing commit 0f8fc2c with merge 960865b... |
|
💔 Test failed - auto-mac-64-opt |
| @@ -415,8 +415,7 @@ impl CStr { | |||
| /// | |||
There was a problem hiding this comment.
you need to remove the use std::str up on line 410, now that str isn't being used anymore.
There was a problem hiding this comment.
done, thanks @steveklabnik
Documentation of `CStr::from_ptr` suggests using `str::from_utf8(slice.to_bytes()).unwrap()` to obtain a `&str` but `CStr` has `CStr::to_str` that does exactly that. (First PR, be nice :)
Documentation of `CStr::from_ptr` suggests using `str::from_utf8(slice.to_bytes()).unwrap()` to obtain a `&str` but `CStr` has `CStr::to_str` that does exactly that. (First PR, be nice :)
Documentation of
CStr::from_ptrsuggests usingstr::from_utf8(slice.to_bytes()).unwrap()to obtain a
&strbutCStrhasCStr::to_strthat does exactly that.(First PR, be nice :)