Whitelisting PatWild for E0022 (fixes #28822) #28938
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| fn main() {} | ||
|
|
||
| const fn size_ofs(_: usize) {} | ||
| const fn size_ofs2(_foo: usize) {} |
There was a problem hiding this comment.
nit: there should be a newline at the end of the file
|
Looks good to me! Minor nit and we can land this. (Just use ``git commit --amend`, no need to create a new commit) I usually have a "second bug" in my pocket for people to work on, but I'm a bit busy with school stuff right now so it might take me a day or two to get to this. In the meantime, you can find easy issues here, #28518 looks pretty easy since it's just tests. I'll look for something substantial but easy in the compiler for you to work on in a few days (remind me if I forget) |
|
Ok @Manishearth I (force) updated the current commit. It has the newline amended to it. Thanks for the help. I will take a look at #28518 later today :) Let me know if something is wrong with this pull request and in case you find more issues you think are suitable for me :) |
|
@bors r+ rollup LGTM, thanks! |
|
📌 Commit 5554636 has been approved by |
Here is my attempt to resolve issue #28822, @Manishearth. Please let me know if it's fine. And if not, what should I do instead? This issue felt like quite a good start for some rust contributions. It allows me to get used to the workflow and codebase of rust in an easy-to-swallow manner. Are there any other issues you would recommend me to look at? :) Would love to do some more stuff!
Here is my attempt to resolve issue #28822, @Manishearth.
Please let me know if it's fine. And if not, what should I do instead?
This issue felt like quite a good start for some rust contributions. It allows me to get used to the workflow and codebase of rust in an easy-to-swallow manner. Are there any other issues you would recommend me to look at? :) Would love to do some more stuff!