Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that all collections work with zero-sized types (ZST) #28518

Closed
bluss opened this issue Sep 19, 2015 · 8 comments
Closed

Test that all collections work with zero-sized types (ZST) #28518

bluss opened this issue Sep 19, 2015 · 8 comments
Labels
A-collections Area: `std::collections` E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@bluss
Copy link
Member

bluss commented Sep 19, 2015

In light of #28488, add tests to the testsuite that exercise all collections using ZST. Most common ZST is the () (empty tuple), and all collections need to support it.

@bluss bluss added A-collections Area: `std::collections` E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Sep 19, 2015
@apasel422
Copy link
Contributor

CC #28493.

@GlenDC
Copy link
Contributor

GlenDC commented Oct 10, 2015

I'm ok to do this :) I will jump on it today if that's alright :)

@apasel422
Copy link
Contributor

@GlenDC Go for it!

@apasel422
Copy link
Contributor

@GlenDC Are you still working on this?

@GlenDC
Copy link
Contributor

GlenDC commented Nov 23, 2015

I wasn't, but if that's fine for you I would like to retake work on this
tomorrow. I suddenly had a lot on my mind as my life will be changing a lot
from christmas on. But you revived me, so to speak. :) I will try to push a
proposed solution by tomorrow or the day after!

On 23 November 2015 at 19:39, Andrew Paseltiner notifications@github.com
wrote:

@GlenDC https://github.com/GlenDC Are you still working on this?


Reply to this email directly or view it on GitHub
#28518 (comment).

with kind regards

De Cauwsemaecker Glen
Game developer and
Open Source Hacker

http://www.glendc.com/

@apasel422
Copy link
Contributor

@GlenDC Sure, go right ahead. No rush!

@KiChjang
Copy link
Member

I think I'll take this, since there's radio silence on this issue.

@GlenDC
Copy link
Contributor

GlenDC commented Jan 16, 2016

@KiChjang yes please. Sorry, for being a roadblock. Thanks for taking it over :)

bors added a commit that referenced this issue Jan 18, 2016
…luss

Encountered while I was trying to work on #28518. Please let me know whether this is a correct move.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-collections Area: `std::collections` E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

4 participants