-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not merge] Another attempt to fix 32-bit MSVC CI #137746
Conversation
@bors try |
[do not merge] Another attempt to fix 32-bit MSVC CI r? `@ghost` try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
This comment has been minimized.
This comment has been minimized.
@bors try |
[do not merge] Another attempt to fix 32-bit MSVC CI r? `@ghost` try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
@bors try |
[do not merge] Another attempt to fix 32-bit MSVC CI r? `@ghost` try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
@bors try |
[do not merge] Another attempt to fix 32-bit MSVC CI r? `@ghost` try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
@bors try |
[do not merge] Another attempt to fix 32-bit MSVC CI r? `@ghost` try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
@bors try |
[do not merge] Another attempt to fix 32-bit MSVC CI r? `@ghost` try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
I think mixing mingw bash and cmd.exe is going to be painful. Maybe try setting the shell to powershell and do: # Get the install path
$vs = &"${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe" -latest -format value -property installationPath
# Run vcvarsall and capture the environment
cmd /c "`"$vs\VC\Auxiliary\Build\vcvarsall.bat`" amd64_x86 10.0.22621.0 & SET" >> $GITHUB_ENV |
@bors try |
[do not merge] Another attempt to fix 32-bit MSVC CI r? `@ghost` try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
@bors try |
[do not merge] Another attempt to fix 32-bit MSVC CI r? `@ghost` try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
@bors try |
[do not merge] Another attempt to fix 32-bit MSVC CI r? `@ghost` try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors try |
[do not merge] Another attempt to fix 32-bit MSVC CI r? `@ghost` try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors try |
[do not merge] Another attempt to fix 32-bit MSVC CI r? `@ghost` try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
Since #137732 looks like it could work, I'm going to wrap this one up. In the end I managed to revert to an older SDK (thanks Chris!), but the build fails, and I really don't want to debug that. |
r? @ghost
try-job: i686-msvc-1
try-job: i686-msvc-2
try-job: dist-i686-msvc