-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Windows 2019 for 32-bit MSVC CI jobs #137732
Conversation
@bors try |
Use Windows 2019 for 32-bit MVSC CI jobs Windows 2022 runner images have been updated today, which brought with itself an unfortunate problem with compiling C code (see rust-lang/cc-rs#1425 for more details). This is a temporary hotfix to try to unblock our CI. r? `@jieyouxu` try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, r=me if the try jobs come back green as a temporary mitigation to unblock the queue.
@bors p=101 (to unblock queue) |
5023d59
to
14fa135
Compare
This comment has been minimized.
This comment has been minimized.
Well that's problematic. Maybe memory usage? |
Looking at this test, it's memory usage regression test for a diagnostics, so I'm inclined to temporarily disable it on 32-bit msvc to not block this. Slap a |
@bors try |
Use Windows 2019 for 32-bit MVSC CI jobs Windows 2022 runner images have been updated today, which brought with itself an unfortunate problem with compiling C code (see rust-lang/cc-rs#1425 or rust-lang#137733 for more details). This is a temporary hotfix to try to unblock our CI. r? `@jieyouxu` try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
Nvm I forgor to bless... |
…6-pc-windows-msvc`
a3af11e
to
ba32a0a
Compare
@bors try |
Use Windows 2019 for 32-bit MVSC CI jobs Windows 2022 runner images have been updated today, which brought with itself an unfortunate problem with compiling C code (see rust-lang/cc-rs#1425 or rust-lang#137733 for more details). This is a temporary hotfix to try to unblock our CI. r? `@jieyouxu` try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
I assume this will be needed for beta, and stable only if there's a point release for other reasons. @rustbot label +beta-nominated +stable-nominated |
nit: the title and commit mixed up "MVSC" |
It's a new Windows target 😆 |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
Oh that is not going to work. The older msvc toolchain has a cdb that's a different version... |
Windows 2022 runner images have been updated today, which brought with itself an unfortunate problem with compiling C code (see rust-lang/cc-rs#1425 or #137733 for more details).
This is a temporary hotfix to try to unblock our CI.
r? @jieyouxu
try-job: i686-msvc-1
try-job: i686-msvc-2
try-job: dist-i686-msvc