set rustc dylib on manually constructed rustc command #136309

onur-ozkan · 2025-01-30T16:57:23Z

rustbot · 2025-01-30T16:57:33Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

src/bootstrap/src/core/builder/cargo.rs

Signed-off-by: onur-ozkan <work@onurozkan.dev>

jieyouxu

Thanks

jieyouxu · 2025-01-31T11:12:55Z

r? jieyouxu @bors r+ rollup

bors · 2025-01-31T11:12:59Z

📌 Commit 139d6ba has been approved by jieyouxu

It is now in the queue for this repository.

Fix is rust-lang/rust#136309 confirmed to work as intended.

arthurzam · 2025-01-31T12:54:31Z

Tested it now, and I can also confirm it fixed all the cross issues for Gentoo. Now I can cross compile rust toolchain to those triplets (using same setup we did for <=1.82): mips-linux-gnu, mipsel-linux-gnu, mips64-linux-gnuabi64, mips64el-linux-gnuabi64, riscv64-linux-musl, powerpc64le-linux-musl, powerpc64-linux-musl, sparc64-linux-gnu.

set rustc dylib on manually constructed rustc command Fixes rust-lang#133629

…kingjubilee Rollup of 16 pull requests Successful merges: - rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu) - rust-lang#135768 (tests: Port `symbol-mangling-hashed` to rmake.rs) - rust-lang#135836 (bootstrap: only build `crt{begin,end}.o` when compiling to MUSL) - rust-lang#135840 (omit unused args warnings for intrinsics without body) - rust-lang#135900 (Manually walk into WF obligations in `BestObligation` proof tree visitor) - rust-lang#136146 (Explicitly choose x86 softfloat/hardfloat ABI) - rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe}) - rust-lang#136163 (Fix off-by-one error causing slice::sort to abort the program) - rust-lang#136266 (fix broken release notes id) - rust-lang#136283 (Update encode_utf16 to mention it is native endian) - rust-lang#136309 (set rustc dylib on manually constructed rustc command) - rust-lang#136314 (Use proper type when applying deref adjustment in const) - rust-lang#136339 (CompileTest: Add Directives to Ignore `arm-unknown-*` Targets) - rust-lang#136348 (miri: make float min/max non-deterministic) - rust-lang#136351 (Add documentation for derive(CoercePointee)) - rust-lang#136358 (`#[optimize(none)]` implies `#[inline(never)]`) Failed merges: - rust-lang#135994 (Rename rustc_middle::Ty::is_unsafe_ptr to is_raw_ptr) r? `@ghost` `@rustbot` modify labels: rollup

set rustc dylib on manually constructed rustc command Fixes rust-lang#133629

Rollup of 11 pull requests Successful merges: - rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu) - rust-lang#134740 (Add amdgpu target) - rust-lang#135836 (bootstrap: only build `crt{begin,end}.o` when compiling to MUSL) - rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe}) - rust-lang#136279 (Rename `tcx.ensure()` to `tcx.ensure_ok()`, and improve the associated docs) - rust-lang#136283 (Update encode_utf16 to mention it is native endian) - rust-lang#136309 (set rustc dylib on manually constructed rustc command) - rust-lang#136328 (Rework "long type names" printing logic) - rust-lang#136339 (CompileTest: Add Directives to Ignore `arm-unknown-*` Targets) - rust-lang#136358 (`#[optimize(none)]` implies `#[inline(never)]`) - rust-lang#136368 (Make comma separated lists of anything easier to make for errors) r? `@ghost` `@rustbot` modify labels: rollup

set rustc dylib on manually constructed rustc command Fixes rust-lang#133629

Rollup of 10 pull requests Successful merges: - rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu) - rust-lang#134740 (Add amdgpu target) - rust-lang#135836 (bootstrap: only build `crt{begin,end}.o` when compiling to MUSL) - rust-lang#136279 (Rename `tcx.ensure()` to `tcx.ensure_ok()`, and improve the associated docs) - rust-lang#136283 (Update encode_utf16 to mention it is native endian) - rust-lang#136309 (set rustc dylib on manually constructed rustc command) - rust-lang#136328 (Rework "long type names" printing logic) - rust-lang#136339 (CompileTest: Add Directives to Ignore `arm-unknown-*` Targets) - rust-lang#136358 (`#[optimize(none)]` implies `#[inline(never)]`) - rust-lang#136368 (Make comma separated lists of anything easier to make for errors) r? `@ghost` `@rustbot` modify labels: rollup try-job: dist-powerpc64-linux

set rustc dylib on manually constructed rustc command Fixes rust-lang#133629

Rollup of 11 pull requests Successful merges: - rust-lang#133266 (ci: fix explanation why LLVM download is disabled for windows-gnu) - rust-lang#134740 (Add amdgpu target) - rust-lang#135836 (bootstrap: only build `crt{begin,end}.o` when compiling to MUSL) - rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe}) - rust-lang#136279 (Rename `tcx.ensure()` to `tcx.ensure_ok()`, and improve the associated docs) - rust-lang#136283 (Update encode_utf16 to mention it is native endian) - rust-lang#136309 (set rustc dylib on manually constructed rustc command) - rust-lang#136328 (Rework "long type names" printing logic) - rust-lang#136339 (CompileTest: Add Directives to Ignore `arm-unknown-*` Targets) - rust-lang#136358 (`#[optimize(none)]` implies `#[inline(never)]`) - rust-lang#136368 (Make comma separated lists of anything easier to make for errors) r? `@ghost` `@rustbot` modify labels: rollup try-job: dist-powerpc64-linux

matthiaskrgr · 2025-02-02T11:27:10Z

@bors rollup=iffy

saethlin · 2025-02-02T19:59:28Z

Just to check if this is the cause of the distcheck failures above:

@bors try

bors · 2025-02-02T19:59:30Z

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

saethlin · 2025-02-02T20:00:49Z

Oh. This.

saethlin · 2025-02-02T20:01:18Z

@bors r-

saethlin · 2025-02-02T20:02:27Z

@bors try

bors · 2025-02-02T20:03:38Z

⌛ Trying commit 139d6ba with merge b2bfcc1...

set rustc dylib on manually constructed rustc command Fixes rust-lang#133629 try-job: x86_64-gnu-distcheck

bors · 2025-02-02T21:24:51Z

☀️ Try build successful - checks-actions
Build commit: b2bfcc1 (b2bfcc1dcccb6293437c3b92379448fc965369ed)

saethlin · 2025-02-02T21:29:36Z

@bors r=jieyouxu rollup

bors · 2025-02-02T21:29:39Z

📌 Commit 139d6ba has been approved by jieyouxu

It is now in the queue for this repository.

set rustc dylib on manually constructed rustc command Fixes rust-lang#133629

Rollup of 8 pull requests Successful merges: - rust-lang#134807 (fix(rustdoc): always use a channel when linking to doc.rust-lang.org) - rust-lang#134814 (Add `kl` and `widekl` target features, and the feature gate) - rust-lang#135836 (bootstrap: only build `crt{begin,end}.o` when compiling to MUSL) - rust-lang#136022 (Port ui/simd tests to use the intrinsic macro) - rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern) - rust-lang#136309 (set rustc dylib on manually constructed rustc command) - rust-lang#136392 (bootstrap: add wrapper macros for `feature = "tracing"`-gated `tracing` macros) - rust-lang#136462 (mir_build: Simplify `lower_pattern_range_endpoint`) r? `@ghost` `@rustbot` modify labels: rollup

set rustc dylib on manually constructed rustc command Fixes rust-lang#133629

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#134807 (fix(rustdoc): always use a channel when linking to doc.rust-lang.org) - rust-lang#134814 (Add `kl` and `widekl` target features, and the feature gate) - rust-lang#135836 (bootstrap: only build `crt{begin,end}.o` when compiling to MUSL) - rust-lang#136022 (Port ui/simd tests to use the intrinsic macro) - rust-lang#136309 (set rustc dylib on manually constructed rustc command) - rust-lang#136392 (bootstrap: add wrapper macros for `feature = "tracing"`-gated `tracing` macros) - rust-lang#136462 (mir_build: Simplify `lower_pattern_range_endpoint`) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#134807 (fix(rustdoc): always use a channel when linking to doc.rust-lang.org) - rust-lang#134814 (Add `kl` and `widekl` target features, and the feature gate) - rust-lang#135836 (bootstrap: only build `crt{begin,end}.o` when compiling to MUSL) - rust-lang#136022 (Port ui/simd tests to use the intrinsic macro) - rust-lang#136309 (set rustc dylib on manually constructed rustc command) - rust-lang#136462 (mir_build: Simplify `lower_pattern_range_endpoint`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#136309 - onur-ozkan:133629, r=jieyouxu set rustc dylib on manually constructed rustc command Fixes rust-lang#133629

rustbot assigned Mark-Simulacrum Jan 30, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 30, 2025

onur-ozkan mentioned this pull request Jan 30, 2025

Cross-building rust 1.83.0 on & for NetBSD failure #133629

Closed

jyn514 reviewed Jan 30, 2025

View reviewed changes

src/bootstrap/src/core/builder/cargo.rs Outdated Show resolved Hide resolved

set rustc dylib on manually constructed rustc command

139d6ba

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan force-pushed the 133629 branch from 92665d3 to 139d6ba Compare January 30, 2025 20:32

onur-ozkan changed the title ~~allow failure on proc-macro crate check~~ set rustc dylib on manually constructed rustc command Jan 30, 2025

jieyouxu approved these changes Jan 31, 2025

View reviewed changes

rustbot assigned jieyouxu Jan 31, 2025

rustbot unassigned Mark-Simulacrum Jan 31, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2025

wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request Jan 31, 2025

rust183: re-do fix to issue #133629 by applying upstream fix.

831b81f

Fix is rust-lang/rust#136309 confirmed to work as intended.

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jan 31, 2025

Rollup merge of rust-lang#136309 - onur-ozkan:133629, r=jieyouxu

d82d0c2

set rustc dylib on manually constructed rustc command Fixes rust-lang#133629

workingjubilee mentioned this pull request Jan 31, 2025

Rollup of 16 pull requests #136367

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 1, 2025

Rollup merge of rust-lang#136309 - onur-ozkan:133629, r=jieyouxu

d5525f5

set rustc dylib on manually constructed rustc command Fixes rust-lang#133629

jhpratt mentioned this pull request Feb 1, 2025

Rollup of 11 pull requests #136378

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 1, 2025

Rollup merge of rust-lang#136309 - onur-ozkan:133629, r=jieyouxu

7d480ea

set rustc dylib on manually constructed rustc command Fixes rust-lang#133629

matthiaskrgr mentioned this pull request Feb 1, 2025

Rollup of 10 pull requests #136380

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 1, 2025

Rollup merge of rust-lang#136309 - onur-ozkan:133629, r=jieyouxu

2f1f348

set rustc dylib on manually constructed rustc command Fixes rust-lang#133629

matthiaskrgr mentioned this pull request Feb 1, 2025

Rollup of 5 pull requests #136387

Closed

matthiaskrgr mentioned this pull request Feb 2, 2025

Rollup of 8 pull requests #136399

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 2, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 2, 2025

Auto merge of rust-lang#136309 - onur-ozkan:133629, r=<try>

b2bfcc1

set rustc dylib on manually constructed rustc command Fixes rust-lang#133629 try-job: x86_64-gnu-distcheck

workingjubilee mentioned this pull request Feb 2, 2025

Add amdgpu target #134740

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 2, 2025

jieyouxu added a commit to jieyouxu/rust that referenced this pull request Feb 3, 2025

Rollup merge of rust-lang#136309 - onur-ozkan:133629, r=jieyouxu

a60a7c3

set rustc dylib on manually constructed rustc command Fixes rust-lang#133629

jieyouxu mentioned this pull request Feb 3, 2025

Rollup of 8 pull requests #136482

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 3, 2025

Rollup merge of rust-lang#136309 - onur-ozkan:133629, r=jieyouxu

a2885a6

set rustc dylib on manually constructed rustc command Fixes rust-lang#133629

matthiaskrgr mentioned this pull request Feb 3, 2025

Rollup of 7 pull requests #136506

Closed

matthiaskrgr mentioned this pull request Feb 4, 2025

Rollup of 6 pull requests #136525

Merged

bors merged commit a24d859 into rust-lang:master Feb 4, 2025
7 checks passed

rustbot added this to the 1.86.0 milestone Feb 4, 2025

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2025

Unrolled build for rust-lang#136309

25fdcd3

Rollup merge of rust-lang#136309 - onur-ozkan:133629, r=jieyouxu set rustc dylib on manually constructed rustc command Fixes rust-lang#133629

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

set rustc dylib on manually constructed rustc command #136309

set rustc dylib on manually constructed rustc command #136309

onur-ozkan commented Jan 30, 2025 •

edited by saethlin

Loading

rustbot commented Jan 30, 2025

jieyouxu left a comment

jieyouxu commented Jan 31, 2025

bors commented Jan 31, 2025

arthurzam commented Jan 31, 2025

matthiaskrgr commented Feb 2, 2025

saethlin commented Feb 2, 2025

bors commented Feb 2, 2025

saethlin commented Feb 2, 2025

saethlin commented Feb 2, 2025

saethlin commented Feb 2, 2025

bors commented Feb 2, 2025

bors commented Feb 2, 2025

saethlin commented Feb 2, 2025

bors commented Feb 2, 2025

set rustc dylib on manually constructed rustc command #136309

set rustc dylib on manually constructed rustc command #136309

Conversation

onur-ozkan commented Jan 30, 2025 • edited by saethlin Loading

rustbot commented Jan 30, 2025

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu commented Jan 31, 2025

bors commented Jan 31, 2025

arthurzam commented Jan 31, 2025

matthiaskrgr commented Feb 2, 2025

saethlin commented Feb 2, 2025

bors commented Feb 2, 2025

saethlin commented Feb 2, 2025

saethlin commented Feb 2, 2025

saethlin commented Feb 2, 2025

bors commented Feb 2, 2025

bors commented Feb 2, 2025

saethlin commented Feb 2, 2025

bors commented Feb 2, 2025

onur-ozkan commented Jan 30, 2025 •

edited by saethlin

Loading