Add kl and widekl target features, and the feature gate
#134814
Merged
+26
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #134794) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? compiler |
|
The tracking issue is a bit sparse on what the plan here is. Please add some intrinsics you'll be adding in the future and maybe show a small code snippet about how these will be used in the future. I'm not sure where we document individual target features, @veluca93 is there anything like this? Should we start having such documentation? |
|
AFAIU the stabilized target features are documented (at least) here: https://doc.rust-lang.org/reference/attributes/codegen.html#the-target_feature-attribute |
|
I cannot add intrinsics until the target feature is added, because And for clarity, |
|
Sorry, not trying to hold this up. It's just a bit outside my comfort zone. What I meant was "add some info to the issue" like just an example intrinsic and an example how a caller could look. Doesn't need to block this PR tho @bors r+ rollup |
|
Ah ok, no problems. I would add an example intrinsic in the issue |
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Feb 3, 2025
Add `kl` and `widekl` target features, and the feature gate This is an effort towards rust-lang#134813. This PR adds the target-features and the feature gate to `rustc` <!-- `@rustbot` label O-x86_64 O-x86_32 A-target-feature r? compiler -->
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 3, 2025
Rollup of 8 pull requests Successful merges: - rust-lang#134807 (fix(rustdoc): always use a channel when linking to doc.rust-lang.org) - rust-lang#134814 (Add `kl` and `widekl` target features, and the feature gate) - rust-lang#135836 (bootstrap: only build `crt{begin,end}.o` when compiling to MUSL) - rust-lang#136022 (Port ui/simd tests to use the intrinsic macro) - rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern) - rust-lang#136309 (set rustc dylib on manually constructed rustc command) - rust-lang#136392 (bootstrap: add wrapper macros for `feature = "tracing"`-gated `tracing` macros) - rust-lang#136462 (mir_build: Simplify `lower_pattern_range_endpoint`) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 3, 2025
Add `kl` and `widekl` target features, and the feature gate This is an effort towards rust-lang#134813. This PR adds the target-features and the feature gate to `rustc` <!-- ``@rustbot`` label O-x86_64 O-x86_32 A-target-feature r? compiler -->
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 4, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#134807 (fix(rustdoc): always use a channel when linking to doc.rust-lang.org) - rust-lang#134814 (Add `kl` and `widekl` target features, and the feature gate) - rust-lang#135836 (bootstrap: only build `crt{begin,end}.o` when compiling to MUSL) - rust-lang#136022 (Port ui/simd tests to use the intrinsic macro) - rust-lang#136309 (set rustc dylib on manually constructed rustc command) - rust-lang#136392 (bootstrap: add wrapper macros for `feature = "tracing"`-gated `tracing` macros) - rust-lang#136462 (mir_build: Simplify `lower_pattern_range_endpoint`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 4, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#134807 (fix(rustdoc): always use a channel when linking to doc.rust-lang.org) - rust-lang#134814 (Add `kl` and `widekl` target features, and the feature gate) - rust-lang#135836 (bootstrap: only build `crt{begin,end}.o` when compiling to MUSL) - rust-lang#136022 (Port ui/simd tests to use the intrinsic macro) - rust-lang#136309 (set rustc dylib on manually constructed rustc command) - rust-lang#136462 (mir_build: Simplify `lower_pattern_range_endpoint`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 4, 2025
Rollup merge of rust-lang#134814 - sayantn:keylocker, r=oli-obk Add `kl` and `widekl` target features, and the feature gate This is an effort towards rust-lang#134813. This PR adds the target-features and the feature gate to `rustc` <!-- ```@rustbot``` label O-x86_64 O-x86_32 A-target-feature r? compiler -->
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an effort towards #134813. This PR adds the target-features and the feature gate to
rustc