Rollup of 7 pull requests #135916
Closed
Rollup of 7 pull requests #135916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These targets have always generated DWARF debuginfo and not CodeView/PDB debuginfo like the MSVC Windows targets. Correct their target definitions to reflect this. The newly added tests for the various combinations of `*-windows-gnu*` targets and `-Csplit-debuginfo` show that this does not change any stable behavior.
This was added years ago and is outdated today. Signed-off-by: onur-ozkan <work@onurozkan.dev>
…n-WF type in new solver
…-wf-coerce-ice, r=lcnr Don't ICE in coerce when autoderef fails to structurally normalize non-WF type in new solver r? lcnr
…uginfokind, r=lqd Update windows-gnu targets to set `DebuginfoKind::DWARF` These targets have always used DWARF debuginfo and not CodeView/PDB debuginfo like the MSVC Windows targets. However, their target definitions claim to use `DebuginfoKind::PDB` probably to ensure that we do not try to allow the use of split-DWARF debuginfo. This does not appear to be necessary since the targets set their supported split debug info to `Off`. I've looked at all of the uses of these properties and this patch does not appear to cause any functional changes in compiler behavior. I also added UI tests to attempt to validate there is no change in the behavior of these options on stable compilers. cc ```@mati865``` since you mentioned this in rust-lang#135739 cc ```@davidtwco``` for split-dwarf
…=Kobzol ci: use 8 core arm runner for dist-aarch64-linux try-job: dist-aarch64-linux
…eyouxu fix outdated file path ref in llvm This was added years ago and is outdated today.
…_mut, r=tgross35 Remove erroneous `unsafe` in `BTreeSet::upper_bound_mut` rust-lang#128309 (comment) Tracking issue: rust-lang#107540
remove implied end of slice
rustdoc-json-types: Finalize dyn compatibility renaming Followup to rust-lang#131595. Part of rust-lang#130852. Inspired by rust-lang#135858 (does the same thing but for the rustdoc-types docs). r? ```@fmease```
|
Could not assign reviewer from: |
|
rustbot has assigned @compiler-errors. Use |
|
bors r plus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
DebuginfoKind::DWARF#135790 (Update windows-gnu targets to setDebuginfoKind::DWARF)unsafeinBTreeSet::upper_bound_mut#135883 (Remove erroneousunsafeinBTreeSet::upper_bound_mut)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup