-Znext-solver: "normalize" signature before checking it mentions self in deduce_closure_signature
#135892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changes to |
BoxyUwU
commented
Jan 22, 2025
Comment on lines
+129
to
+131
| // such aliases while having a different `GoalSource`. Closure signature inference | ||
| // however can't really handle *every* higher ranked `Fn` goal also being present | ||
| // in the form of `?c: Fn<(<?x as Trait<'!a>>::Assoc)`. |
There was a problem hiding this comment.
This comment feels a bit detached from where closure signature inference is located xd
|
@bors r+ rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 28, 2025
…malized, r=lcnr -Znext-solver: "normalize" signature before checking it mentions self in `deduce_closure_signature` Fixes rust-lang/trait-system-refactor-initiative#138 r? `@lcnr` Tbh I wrote so much comments I don't feel like writing it all again but as a description.
|
heads up this seems to have caused some failure here #136184 (comment) |
|
@bors r- |
|
I vaguelly remember that test failure from one of my new solver PRs recently, probably should rebase |
433c887 to
356b2aa
Compare
|
@bors r=lcnr |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 28, 2025
…malized, r=lcnr -Znext-solver: "normalize" signature before checking it mentions self in `deduce_closure_signature` Fixes rust-lang/trait-system-refactor-initiative#138 r? `@lcnr` Tbh I wrote so much comments I don't feel like writing it all again but as a description.
This was referenced Jan 28, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2025
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#135869 (Make docs for AtomicUsize::from_mut platform-independent) - rust-lang#135892 (-Znext-solver: "normalize" signature before checking it mentions self in `deduce_closure_signature`) - rust-lang#136055 (Implement MIR const trait stability checks) - rust-lang#136066 (Pass spans to `perform_locally_in_new_solver`) - rust-lang#136071 ([Clippy] Add vec_reserve & vecdeque_reserve diagnostic items) - rust-lang#136124 (Arbitrary self types v2: explain test.) - rust-lang#136149 (Flip the `rustc-rayon`/`indexmap` dependency order) - rust-lang#136173 (Update comments and sort target_arch in c_char_definition) - rust-lang#136178 (Update username in build helper example) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2025
Rollup merge of rust-lang#135892 - BoxyUwU:next_solver_deduce_sig_normalized, r=lcnr -Znext-solver: "normalize" signature before checking it mentions self in `deduce_closure_signature` Fixes rust-lang/trait-system-refactor-initiative#138 r? ``@lcnr`` Tbh I wrote so much comments I don't feel like writing it all again but as a description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/trait-system-refactor-initiative#138
r? @lcnr
Tbh I wrote so much comments I don't feel like writing it all again but as a description.