Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make docs for AtomicUsize::from_mut platform-independent #135869

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Make docs for AtomicUsize::from_mut platform-independent #135869

merged 1 commit into from
Jan 28, 2025

Conversation

hkBst
Copy link
Contributor

@hkBst hkBst commented Jan 22, 2025

fixes #133342

@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2025

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 22, 2025
Noratrieb
Noratrieb requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ARandomDev99 has already claimed this issue, please avoid opening PRs for issues other people have claimed already next time.
You've already done it here so it's fine, I've added some feedback for the wording and when that's changed we can merge it.

library/core/src/sync/atomic.rs Outdated Show resolved Hide resolved
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2025
@hkBst
Copy link
Contributor Author

hkBst commented Jan 28, 2025 •
edited
Loading

@Noratrieb I think I was working on this issue when it got claimed, which is why I did not notice, and I haven't gotten into the habit of claiming myself yet.
@ARandomDev99 Sorry Aneesh! No harm was intended.

@ARandomDev99
Copy link
Contributor

All good. I didn't make much progress myself. :)

@hkBst
Copy link
Contributor Author

hkBst commented Jan 28, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 28, 2025
@Noratrieb
Copy link
Member

Thanks, all good then. I reconning claiming it then next time before working on it, E-easy issues are always very contended :D
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 28, 2025

📌 Commit aa1f941 has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2025
@hkBst
Copy link
Contributor Author

hkBst commented Jan 28, 2025

E-easy issues are always very contended :D

I'll try to avoid those in future ;P

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 28, 2025
@matthiaskrgr
Rollup merge of rust-lang#135869 - hkBst:patch-12, r=Noratrieb
b5284a4 
Make docs for AtomicUsize::from_mut platform-independent

fixes rust-lang#133342
This was referenced Jan 28, 2025
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2025
@bors
Auto merge of rust-lang#136203 - matthiaskrgr:rollup-1k0f44l, r=matth…
bf1b174 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#135869 (Make docs for AtomicUsize::from_mut platform-independent)
 - rust-lang#135892 (-Znext-solver: "normalize" signature before checking it mentions self in `deduce_closure_signature`)
 - rust-lang#136055 (Implement MIR const trait stability checks)
 - rust-lang#136066 (Pass spans to `perform_locally_in_new_solver`)
 - rust-lang#136071 ([Clippy] Add vec_reserve & vecdeque_reserve diagnostic items)
 - rust-lang#136124 (Arbitrary self types v2: explain test.)
 - rust-lang#136149 (Flip the `rustc-rayon`/`indexmap` dependency order)
 - rust-lang#136173 (Update comments and sort target_arch in c_char_definition)
 - rust-lang#136178 (Update username in build helper example)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6b4757b into rust-lang:master Jan 28, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 28, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2025
@rust-timer
Unrolled build for rust-lang#135869
8cb07e6 
Rollup merge of rust-lang#135869 - hkBst:patch-12, r=Noratrieb

Make docs for AtomicUsize::from_mut platform-independent

fixes rust-lang#133342
@hkBst hkBst deleted the patch-12 branch February 2, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb requested changes

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.

AtomicUsize::from_mut has incorrect alignment requirements in docs
5 participants
@hkBst @rustbot @ARandomDev99 @Noratrieb @bors