Implement `&pin const self` and `&pin mut self` sugars #135733

frank-king · 2025-01-19T15:34:39Z

This PR implements part of #130494.

It introduces the sugars &pin const self and &pin mut self for self: Pin<&Self> and self: Pin<&mut Self>.

rustbot · 2025-01-19T15:34:47Z

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-01-19T15:34:49Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

compiler-errors

Please add tests to ensure that this sugar is not usable in #[cfg]'d out code.

src/tools/rustfmt/tests/target/pin_sugar.rs

oli-obk · 2025-01-20T10:24:57Z

These changes are more likely to conflict with someone's macro_rules macro out there, so we should probably crater it, too. If there is too much breakage we may hold up on adding this syntax and start with a builtin macro expanding to the same ast nodes that you introduced.

frank-king · 2025-02-15T12:24:32Z

Should I trigger the crater via rustbot or run it locally?

oli-obk · 2025-02-15T16:06:49Z

@bors try

…, r=<try> Implement `&pin const self` and `&pin mut self` sugars This PR implements part of rust-lang#130494. It introduces the sugars `&pin const self` and `&pin mut self` for `self: Pin<&Self>` and `self: Pin<&mut Self>`.

bors · 2025-02-15T16:08:07Z

⌛ Trying commit f3a88c0 with merge f3dc08d...

bors · 2025-02-15T17:57:36Z

☀️ Try build successful - checks-actions
Build commit: f3dc08d (f3dc08d20a1589b87bde75bb82ee6423307f9bde)

traviscross · 2025-02-28T21:47:25Z

cc @traviscross @eholk @tmandry

oli-obk · 2025-02-28T22:04:52Z

@craterbot check

craterbot · 2025-02-28T22:05:07Z

👌 Experiment pr-135733 created and queued.
🤖 Automatically detected try build f3dc08d
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-03-01T14:57:24Z

🚧 Experiment pr-135733 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-03-02T12:23:44Z

🎉 Experiment pr-135733 is completed!
📊 4 regressed and 10 fixed (590198 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

oli-obk · 2025-03-02T13:10:05Z

These changes are more likely to conflict with someone's macro_rules macro out there, so we should probably crater it, too. If there is too much breakage we may hold up on adding this syntax and start with a builtin macro expanding to the same ast nodes that you introduced.

Great, no one was doing this in crates. Bin crates may still do it but it should be super rare.

Let's ship it

tests/ui/feature-gates/feature-gate-pin_ergonomics.rs

tests/ui/async-await/pin-ergonomics/sugar-self.rs

oli-obk · 2025-03-05T16:12:02Z

Thanks!

@bors r+

bors · 2025-03-05T16:12:07Z

📌 Commit 50d0f99 has been approved by oli-obk

It is now in the queue for this repository.

…er, r=oli-obk Implement `&pin const self` and `&pin mut self` sugars This PR implements part of rust-lang#130494. It introduces the sugars `&pin const self` and `&pin mut self` for `self: Pin<&Self>` and `self: Pin<&mut Self>`.

Rollup of 29 pull requests Successful merges: - rust-lang#135733 (Implement `&pin const self` and `&pin mut self` sugars) - rust-lang#137107 (Override default `Write` methods for cursor-like types) - rust-lang#137303 (Remove `MaybeForgetReturn` suggestion) - rust-lang#137327 (Undeprecate env::home_dir) - rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book) - rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden)) - rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var) - rust-lang#137612 (Update bootstrap to edition 2024) - rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck) - rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums) - rust-lang#137685 (self-contained linker: conservatively default to `-znostart-stop-gc` on x64 linux) - rust-lang#137744 (Re-add `Clone`-derive on `Thir`) - rust-lang#137758 (fix usage of ty decl macro fragments in attributes) - rust-lang#137764 (Ensure that negative auto impls are always applicable) - rust-lang#137772 (Fix char count in `Display` for `ByteStr`) - rust-lang#137798 (ci: use ubuntu 24 on arm large runner) - rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee) - rust-lang#137805 (adjust Layout debug printing to match the internal field name) - rust-lang#137808 (Do not require that unsafe fields lack drop glue) - rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists) - rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN) - rust-lang#137827 (Add timestamp to unstable feature usage metrics) - rust-lang#137832 (Fix crash in BufReader::peek()) - rust-lang#137910 (Improve error message for `AsyncFn` trait failure for RPIT) - rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty) - rust-lang#138038 (Update `compiler-builtins` to 0.1.151) - rust-lang#138046 (trim channel value in `get_closest_merge_commit`) - rust-lang#138052 (strip `-Wlinker-messages` wrappers from `rust-lld` rmake test) - rust-lang#138053 (Increase the max. custom try jobs requested to `20`) r? `@ghost` `@rustbot` modify labels: rollup

…er, r=oli-obk Implement `&pin const self` and `&pin mut self` sugars This PR implements part of rust-lang#130494. It introduces the sugars `&pin const self` and `&pin mut self` for `self: Pin<&Self>` and `self: Pin<&mut Self>`.

traviscross · 2025-03-06T00:56:59Z

@bors r-

traviscross · 2025-03-06T00:57:25Z

@bors r=oli-obk,traviscross

To share in any blame here.

bors · 2025-03-06T00:57:28Z

📌 Commit 50d0f99 has been approved by oli-obk,traviscross

It is now in the queue for this repository.

traviscross · 2025-03-06T00:58:43Z

@bors rollup

…er, r=oli-obk,traviscross Implement `&pin const self` and `&pin mut self` sugars This PR implements part of rust-lang#130494. It introduces the sugars `&pin const self` and `&pin mut self` for `self: Pin<&Self>` and `self: Pin<&mut Self>`.

…mpiler-errors Rollup of 25 pull requests Successful merges: - rust-lang#135733 (Implement `&pin const self` and `&pin mut self` sugars) - rust-lang#135895 (Document workings of successors more clearly) - rust-lang#136922 (Pattern types: Avoid having to handle an Option for range ends in the type system or the HIR) - rust-lang#137303 (Remove `MaybeForgetReturn` suggestion) - rust-lang#137327 (Undeprecate env::home_dir) - rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book) - rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden)) - rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var) - rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck) - rust-lang#137643 (Add DWARF test case for non-C-like `repr128` enums) - rust-lang#137744 (Re-add `Clone`-derive on `Thir`) - rust-lang#137758 (fix usage of ty decl macro fragments in attributes) - rust-lang#137764 (Ensure that negative auto impls are always applicable) - rust-lang#137772 (Fix char count in `Display` for `ByteStr`) - rust-lang#137798 (ci: use ubuntu 24 on arm large runner) - rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee) - rust-lang#137805 (adjust Layout debug printing to match the internal field name) - rust-lang#137808 (Do not require that unsafe fields lack drop glue) - rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists) - rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN) - rust-lang#137834 (rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME) - rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe) - rust-lang#137910 (Improve error message for `AsyncFn` trait failure for RPIT) - rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty) - rust-lang#138038 (Update `compiler-builtins` to 0.1.151) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#135733 - frank-king:feature/pin-self-receiver, r=oli-obk,traviscross Implement `&pin const self` and `&pin mut self` sugars This PR implements part of rust-lang#130494. It introduces the sugars `&pin const self` and `&pin mut self` for `self: Pin<&Self>` and `self: Pin<&mut Self>`.

rustbot assigned oli-obk Jan 19, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 19, 2025

compiler-errors previously requested changes Jan 19, 2025

View reviewed changes

ytmimi reviewed Jan 20, 2025

View reviewed changes

src/tools/rustfmt/tests/target/pin_sugar.rs Outdated Show resolved Hide resolved

frank-king force-pushed the feature/pin-self-receiver branch from 07f960b to f3a88c0 Compare January 20, 2025 03:03

oli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2025

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 28, 2025

traviscross mentioned this pull request Mar 2, 2025

Tracking issue for pin ergonomics #130494

Open

13 tasks

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Mar 2, 2025

traviscross reviewed Mar 2, 2025

View reviewed changes

tests/ui/feature-gates/feature-gate-pin_ergonomics.rs Show resolved Hide resolved

traviscross reviewed Mar 2, 2025

View reviewed changes

tests/ui/async-await/pin-ergonomics/sugar-self.rs Outdated Show resolved Hide resolved

traviscross reviewed Mar 2, 2025

View reviewed changes

tests/ui/async-await/pin-ergonomics/sugar-self.rs Outdated Show resolved Hide resolved

frank-king added 3 commits March 5, 2025 22:37

Implement &pin const self and &pin mut self sugars

cb7d687

Simplify parse_self_param

52cd874

Simplify rewrite_explicit_self

50d0f99

frank-king force-pushed the feature/pin-self-receiver branch from 3e7602f to 50d0f99 Compare March 5, 2025 14:57

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2025

jieyouxu mentioned this pull request Mar 5, 2025

Rollup of 29 pull requests #138071

Closed

jieyouxu mentioned this pull request Mar 5, 2025

Rollup of 15 pull requests #138072

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 6, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2025

Noratrieb mentioned this pull request Mar 6, 2025

Rollup of 42 pull requests #138086

Closed

compiler-errors mentioned this pull request Mar 6, 2025

Rollup of 25 pull requests #138114

Merged

bors merged commit 91826b6 into rust-lang:master Mar 7, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Mar 7, 2025

traviscross mentioned this pull request Mar 9, 2025

Implement parsing of pinned borrows #135731

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `&pin const self` and `&pin mut self` sugars #135733

Implement `&pin const self` and `&pin mut self` sugars #135733

frank-king commented Jan 19, 2025

rustbot commented Jan 19, 2025

rustbot commented Jan 19, 2025

compiler-errors left a comment

oli-obk commented Jan 20, 2025

frank-king commented Feb 15, 2025

oli-obk commented Feb 15, 2025

bors commented Feb 15, 2025

bors commented Feb 15, 2025

traviscross commented Feb 28, 2025

oli-obk commented Feb 28, 2025

craterbot commented Feb 28, 2025

craterbot commented Mar 1, 2025

craterbot commented Mar 2, 2025

oli-obk commented Mar 2, 2025

oli-obk commented Mar 5, 2025

bors commented Mar 5, 2025

traviscross commented Mar 6, 2025

traviscross commented Mar 6, 2025

bors commented Mar 6, 2025

traviscross commented Mar 6, 2025

Implement &pin const self and &pin mut self sugars #135733

Implement &pin const self and &pin mut self sugars #135733

Conversation

frank-king commented Jan 19, 2025

rustbot commented Jan 19, 2025

rustbot commented Jan 19, 2025

compiler-errors left a comment

Choose a reason for hiding this comment

oli-obk commented Jan 20, 2025

frank-king commented Feb 15, 2025

oli-obk commented Feb 15, 2025

bors commented Feb 15, 2025

bors commented Feb 15, 2025

traviscross commented Feb 28, 2025

oli-obk commented Feb 28, 2025

craterbot commented Feb 28, 2025

craterbot commented Mar 1, 2025

craterbot commented Mar 2, 2025

oli-obk commented Mar 2, 2025

oli-obk commented Mar 5, 2025

bors commented Mar 5, 2025

traviscross commented Mar 6, 2025

traviscross commented Mar 6, 2025

bors commented Mar 6, 2025

traviscross commented Mar 6, 2025

Implement `&pin const self` and `&pin mut self` sugars #135733

Implement `&pin const self` and `&pin mut self` sugars #135733