-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #135702
Closed
Closed
Rollup of 7 pull requests #135702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jens Reidel <adrian@travitia.xyz>
- Move `make_bcb_counters` out of `CoverageCounters` - Split out `make_node_counter_priority_list` - Flatten `Transcriber` into the function `transcribe_counters`
Making these separate types from `CovTerm` and `Expression` was historically very helpful, but now that most of the counter-creation work is handled by `node_flow` they are no longer needed.
…obzol CI: split i686-msvc job to two free runners try-job: i686-msvc-1 try-job: i686-msvc-2
…ile, r=Kobzol ci: use ghcr ubuntu image for mingw-check-tidy
… r=Kobzol Drop MIPS glibc 2.23 patches that reside in crosstool-ng now These patches were added to crosstool-ng in crosstool-ng/crosstool-ng@b88d338 and are therefore duplicate and fail to apply, breaking builds of `dist-mips*-linux`. I have compile tested `dist-mipsel-linux`, I assume the other targets will work just as fine now.
…errors Fix ICE in resolving associated items as non-bindings Fixes rust-lang#135614 so that imported associated functions of traits can be shadowed by local bindings and associated constants of traits can be used in patterns.
…piler-errors Small `rustc_resolve` cleanups 1. Don't open-code `Reverse` 2. Use slice patterns where possible
…ler-errors coverage: Clean up a few things after the counters overhaul Follow-up to rust-lang#135481. No functional change; this is mostly just deleting or moving code.
Get rid of `ToPolyTraitRef` It's generally a footgun, since it throws away `PredicatePolarity`. This PR doesn't attempt to fix any related bugs having to do with binders or polarity; it just tries to pass through `TraitPredicate`s around instead of `TraitRef`s. There should be basically no functional changes.
@bors r+ rollup=never p=7 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 19, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#135616 (CI: split i686-msvc job to two free runners) - rust-lang#135623 (ci: use ghcr ubuntu image for mingw-check-tidy) - rust-lang#135640 (Drop MIPS glibc 2.23 patches that reside in crosstool-ng now) - rust-lang#135663 (Fix ICE in resolving associated items as non-bindings) - rust-lang#135677 (Small `rustc_resolve` cleanups) - rust-lang#135680 (coverage: Clean up a few things after the counters overhaul) - rust-lang#135697 (Get rid of `ToPolyTraitRef`) r? `@ghost` `@rustbot` modify labels: rollup
#135677 was force pushed since.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_resolve
cleanups #135677 (Smallrustc_resolve
cleanups)ToPolyTraitRef
#135697 (Get rid ofToPolyTraitRef
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup