Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: split i686-msvc job to two free runners #135616

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

marcoieni
Copy link
Member

Split the i686-msvc job in two to move it to free runners and reduce the use of large runners in CI. Related to rust-lang/infra-team#189

This PR is similar to #133632 however the job i686-msvc fails less often than x86_64-msvc in CI, so it can be split more safely.

In the last month, this job failed only 3 times:

image

Datadog link for the infra team.

r? @Kobzol

I opened this PR after #135483 was closed by mistake.

try-job: i686-msvc-1
try-job: i686-msvc-2

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 17, 2025
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2025
CI: split i686-msvc job to two free runners

try-job: i686-msvc-1
try-job: i686-msvc-2
@bors
Copy link
Contributor

bors commented Jan 17, 2025

⌛ Trying commit 48bf86c with merge fed2a72...

@marcoieni marcoieni force-pushed the split-i686-msvc-job branch from 48bf86c to de89ffc Compare January 17, 2025 08:22
@marcoieni
Copy link
Member Author

I'm stopping the try job because I force pushed to change one comment

@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2025
CI: split i686-msvc job to two free runners

try-job: i686-msvc-1
try-job: i686-msvc-2
@bors
Copy link
Contributor

bors commented Jan 17, 2025

⌛ Trying commit de89ffc with merge 07f0996...

@bors
Copy link
Contributor

bors commented Jan 17, 2025

☀️ Try build successful - checks-actions
Build commit: 07f0996 (07f099677fc66c6a60b4fd26da8d70a8bed99010)

@Kobzol
Copy link
Contributor

Kobzol commented Jan 17, 2025

Let's try.

@bors r+

@bors
Copy link
Contributor

bors commented Jan 17, 2025

📌 Commit de89ffc has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 18, 2025
…obzol

CI: split i686-msvc job to two free runners

try-job: i686-msvc-1
try-job: i686-msvc-2
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#135616 (CI: split i686-msvc job to two free runners)
 - rust-lang#135623 (ci: use ghcr ubuntu image for mingw-check-tidy)
 - rust-lang#135640 (Drop MIPS glibc 2.23 patches that reside in crosstool-ng now)
 - rust-lang#135663 (Fix ICE in resolving associated items as non-bindings)
 - rust-lang#135677 (Small `rustc_resolve` cleanups)
 - rust-lang#135680 (coverage: Clean up a few things after the counters overhaul)
 - rust-lang#135697 (Get rid of `ToPolyTraitRef`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2025
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#135616 (CI: split i686-msvc job to two free runners)
 - rust-lang#135623 (ci: use ghcr ubuntu image for mingw-check-tidy)
 - rust-lang#135640 (Drop MIPS glibc 2.23 patches that reside in crosstool-ng now)
 - rust-lang#135663 (Fix ICE in resolving associated items as non-bindings)
 - rust-lang#135680 (coverage: Clean up a few things after the counters overhaul)
 - rust-lang#135697 (Get rid of `ToPolyTraitRef`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8825073 into rust-lang:master Jan 19, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 19, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2025
Rollup merge of rust-lang#135616 - marcoieni:split-i686-msvc-job, r=Kobzol

CI: split i686-msvc job to two free runners

try-job: i686-msvc-1
try-job: i686-msvc-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants