Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reference to dangling from slice::Iter #134570

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

hkBst
Copy link
Contributor

@hkBst hkBst commented Dec 20, 2024

This aligns the comment with reality and with IterMut. Also dangling does not seem to take any arguments.

This aligns the comment with reality and with IterMut. Also dangling does not seem to take any arguments.
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 20, 2024
@joboet
Copy link
Member

joboet commented Dec 20, 2024

Thank you!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 20, 2024

📌 Commit 496adcf has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#134556 ([tiny] fix missing ns units in bootstrap's benchmark rendering)
 - rust-lang#134560 (mri: add track_caller to thread spawning methods for better backtraces)
 - rust-lang#134561 (Reduce the amount of explicit FatalError.raise())
 - rust-lang#134562 (tests/codegen/asm: Remove uses of rustc_attrs and lang_items features by using minicore)
 - rust-lang#134567 (Remove some dead code around import library generation)
 - rust-lang#134570 (remove reference to dangling from slice::Iter)
 - rust-lang#134573 (unimplement `PointerLike` for trait objects)
 - rust-lang#134574 (next-solver: disable unnecessary hack)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 04c804e into rust-lang:master Dec 20, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 20, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
Rollup merge of rust-lang#134570 - hkBst:patch-3, r=joboet

remove reference to dangling from slice::Iter

This aligns the comment with reality and with IterMut. Also dangling does not seem to take any arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants