Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some dead code around import library generation #134567

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Dec 20, 2024

This was missed when replacing the usage of LLVM for generating import libraries.

@bors rollup

This was missed when replacing the usage of LLVM for generating import
libraries.
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 20, 2024
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 20, 2024

📌 Commit c02c311 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 20, 2024
…ler-errors

Remove some dead code around import library generation

This was missed when replacing the usage of LLVM for generating import libraries.

`@bors` rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#134556 ([tiny] fix missing ns units in bootstrap's benchmark rendering)
 - rust-lang#134560 (mri: add track_caller to thread spawning methods for better backtraces)
 - rust-lang#134561 (Reduce the amount of explicit FatalError.raise())
 - rust-lang#134562 (tests/codegen/asm: Remove uses of rustc_attrs and lang_items features by using minicore)
 - rust-lang#134567 (Remove some dead code around import library generation)
 - rust-lang#134570 (remove reference to dangling from slice::Iter)
 - rust-lang#134573 (unimplement `PointerLike` for trait objects)
 - rust-lang#134574 (next-solver: disable unnecessary hack)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9b4aa92 into rust-lang:master Dec 20, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 20, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
Rollup merge of rust-lang#134567 - bjorn3:remove_unused_code, r=compiler-errors

Remove some dead code around import library generation

This was missed when replacing the usage of LLVM for generating import libraries.

``@bors`` rollup
@bjorn3 bjorn3 deleted the remove_unused_code branch December 21, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants