Add windows_sys type definitions for ARM32 manually #112527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ChrisDenton (rustbot has picked a reviewer for you, use r? to override) |
faptc
reviewed
Jun 11, 2023
|
This looks good to me. I might want to think more about how to organise platform support but let's fix this issue first. Could you add a short comment to |
@ChrisDenton I have added some comments in df08f56. Does it makes sense? |
|
Yep makes sense to me, thanks! @bors r+ rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 12, 2023
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#112302 (Suggest using `ptr::null_mut` when user provided `ptr::null` to a function expecting `ptr::null_mut`) - rust-lang#112416 (Fix debug ICE for extern type with where clauses) - rust-lang#112527 (Add windows_sys type definitions for ARM32 manually) - rust-lang#112546 (new solver: extend assert to other aliases) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows_sysbindings do not include platform-specific type definitions for ARM 32 architecture, so it breaksthumbv7a-pc-windows-msvcandthumbv7a-uwp-windows-msvctargets. This PR tries to add them back by manually inserting them together with the generated ones.WSADATAis copied from the generated definition forx86.CONTEXTis copied from the definition beforewindows_sysis introduced (which is just an empty enum):rust/library/std/src/sys/windows/c.rs
Line 802 in 4a18324
Fixes #112265.