Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug ICE for extern type with where clauses #112416

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Fix debug ICE for extern type with where clauses #112416

merged 1 commit into from
Jun 12, 2023

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jun 8, 2023

Fixes #112363.

@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 8, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu force-pushed the issue-112363 branch 2 times, most recently from 98a2ec1 to f33e95c Compare June 8, 2023 09:29
@WaffleLapkin WaffleLapkin self-assigned this Jun 8, 2023
@wesleywiser
Copy link
Member

Thanks @jieyouxu!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 12, 2023

📌 Commit 72421bf has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 12, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 12, 2023
@bors
Auto merge of rust-lang#112563 - matthiaskrgr:rollup-ebetrzi, r=matth…
df77afb 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#112302 (Suggest using `ptr::null_mut` when user provided `ptr::null` to a function expecting `ptr::null_mut`)
 - rust-lang#112416 (Fix debug ICE for extern type with where clauses)
 - rust-lang#112527 (Add windows_sys type definitions for ARM32 manually)
 - rust-lang#112546 (new solver: extend assert to other aliases)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8475a88 into rust-lang:master Jun 12, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 12, 2023
@jieyouxu jieyouxu deleted the issue-112363 branch October 22, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sladyn98 sladyn98 sladyn98 left review comments

@WaffleLapkin WaffleLapkin WaffleLapkin left review comments

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

@WaffleLapkin WaffleLapkin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

debug ice: Span must not be empty and have no suggestion' : span points at "where" but is quite off
7 participants
@jieyouxu @rustbot @rust-log-analyzer @wesleywiser @bors @sladyn98 @WaffleLapkin