Do not ICE for unexpected lifetime with ConstGeneric rib #109222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fine, specific diagnostics are not important there, the important part is that the test goes past name resolution and doesn't produce an ICE while doing that. |
2da86b3 to
827a990
Compare
introducing a new trait name won't affect other diagnostics. |
|
@bors r+ |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 17, 2023
…trochenkov Do not ICE for unexpected lifetime with ConstGeneric rib Fixes rust-lang#109143 r? `@petrochenkov` Combining this test with the previous test will affect the previous diagnostics, so I added a separate test case.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 17, 2023
…trochenkov Do not ICE for unexpected lifetime with ConstGeneric rib Fixes rust-lang#109143 r? ``@petrochenkov`` Combining this test with the previous test will affect the previous diagnostics, so I added a separate test case.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 17, 2023
…trochenkov Do not ICE for unexpected lifetime with ConstGeneric rib Fixes rust-lang#109143 r? ```@petrochenkov``` Combining this test with the previous test will affect the previous diagnostics, so I added a separate test case.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#109102 (Erase escaping late-bound regions when probing for ambiguous associated types) - rust-lang#109200 (Fix index out of bounds in `suggest_trait_fn_ty_for_impl_fn_infer`) - rust-lang#109211 (E0206 - update description ) - rust-lang#109222 (Do not ICE for unexpected lifetime with ConstGeneric rib) - rust-lang#109235 (fallback to lstat when stat fails on Windows) - rust-lang#109248 (Pass the right HIR back from `get_fn_decl`) - rust-lang#109251 (Suggest surrounding the macro with `{}` to interpret as a statement) - rust-lang#109256 (Check for llvm-tools before install) - rust-lang#109257 (resolve: Improve debug impls for `NameBinding`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109143
r? @petrochenkov
Combining this test with the previous test will affect the previous diagnostics, so I added a separate test case.