Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E0206 - update description #109211

Merged
merged 4 commits into from
Mar 18, 2023
Merged

E0206 - update description #109211

merged 4 commits into from
Mar 18, 2023

Conversation

mili-l
Copy link
Contributor

@mili-l mili-l commented Mar 16, 2023

added union to description

@rustbot
Copy link
Collaborator

rustbot commented Mar 16, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 16, 2023
@WaffleLapkin WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2023
@mili-l @WaffleLapkin
Update compiler/rustc_error_codes/src/error_codes/E0206.md
c4bb47a 
Co-authored-by: Waffle Maybe <waffle.lapkin@gmail.com>
WaffleLapkin
WaffleLapkin approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@WaffleLapkin
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 17, 2023

📌 Commit c4bb47a has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 17, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 17, 2023
@matthiaskrgr
Rollup merge of rust-lang#109211 - mili-l:mili_l/update_e0206_descrip…
92a2ab9 
…tion, r=WaffleLapkin

E0206 - update description

added `union` to description
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 17, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 17, 2023
@matthiaskrgr
Rollup merge of rust-lang#109211 - mili-l:mili_l/update_e0206_descrip…
5f9b8ed 
…tion, r=WaffleLapkin

E0206 - update description

added `union` to description
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 17, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 17, 2023
@matthiaskrgr
Rollup merge of rust-lang#109211 - mili-l:mili_l/update_e0206_descrip…
e51f2f3 
…tion, r=WaffleLapkin

E0206 - update description

added `union` to description
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 17, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 18, 2023
@bors
Auto merge of rust-lang#109284 - matthiaskrgr:rollup-aaublsx, r=matth…
85123d2 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#109102 (Erase escaping late-bound regions when probing for ambiguous associated types)
 - rust-lang#109200 (Fix index out of bounds in `suggest_trait_fn_ty_for_impl_fn_infer`)
 - rust-lang#109211 (E0206 - update description )
 - rust-lang#109222 (Do not ICE for unexpected lifetime with ConstGeneric rib)
 - rust-lang#109235 (fallback to lstat when stat fails on Windows)
 - rust-lang#109248 (Pass the right HIR back from `get_fn_decl`)
 - rust-lang#109251 (Suggest surrounding the macro with `{}` to interpret as a statement)
 - rust-lang#109256 (Check for llvm-tools before install)
 - rust-lang#109257 (resolve: Improve debug impls for `NameBinding`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e7d6369 into rust-lang:master Mar 18, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mili-l @rustbot @WaffleLapkin @bors @cjgillot