-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: remove the ability to use E
rather than e
in float literals
#5171
Comments
In my opinion, this is equivalent to disallowing uppercase or lowercase hexadecimal digits (e.g. |
Yeah, I concur with @lifthrasiir , we allow mixed-case hex literals too. There are unfortunately quite a few ways to write numerically-equal numbers. This doesn't strike me as a big deal either way, I was just going with the most common grammars for FP out there. http://rosettacode.org/wiki/Literals/Floating_point |
Good enough for me, I'm not about to argue that we shouldn't allow mixed-case hex literals... though I'm a little tempted. :) |
Improve deployment and documentation **This should be merged shortly after** rust-lang#5172 This extracts the python code that generated the `versions.json` file and now sorts the versions. in addition to that it improves the order on the website, respecting the new `rust-*` directories. The new appearance of the documentation site can be previewed here: https://flip1995.github.io/rust-clippy/ changelog: Add documentation for Clippy stable releases at https://rust-lang.github.io/rust-clippy/
…shearth,llogiq,flip1995 I like to move it, move it GHA now runs in the background for 6 days (rust-lang#5088) Since then ~~15~~ 19 PRs were successfully merged and Travis+Appveyor agreed on the status in every case. ([GitHub PR search query](https://github.com/rust-lang/rust-clippy/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+merged%3A%3E%3D2020-02-12T15%3A42%3A00+sort%3Aupdated-desc+NOT+%5Bgh-pages%5D+in%3Atitle)) Some PRs were: - rust-lang#5163 - rust-lang#5170 - rust-lang#5168 - rust-lang#5173 - rust-lang#5171 - rust-lang#5156 - rust-lang#4809 - rust-lang#5177 - rust-lang#5182 - rust-lang#5183 - rust-lang#5184 - rust-lang#5185 - rust-lang#5186 - rust-lang#5181 - rust-lang#5189 Bug with GHA: - When a rustc PR gets merged between the `integration_build` and the `integration` job, the `integration` job will fail. This happened once in rust-lang#5162, but not in the past 6 days. Even if it would happen every 4th PR we would save time, since splitting up the integration build and tests saves 5-7 minutes per run and a complete run takes 15-17 minutes - Sometimes the MacOS build takes up to an hour to download the master toolchain. Until now, this happend 2 or 3 times and can be resolved by a `@bors r3try`+canceling the previous run (restarting single jobs is not supported yet) ## Before merging this, rust-lang/rust-central-station#578 has to get merged This PR is for starting the discussion and to get consensus (@rust-lang/clippy) on a final move to GHA. If we're ready, I'll contact Pietro, to finalize the move. changelog: Clippy completely runs on GHA now 🎉 --- BTW: The deployment already runs on GHA, instead of Travis.
* Fix formatting of comments in empty structs * Add tests * Add single line tests * Fix block comments * Revert changes of test source files
Right now both of the following are legal:
In the interest of There's Only One Way To Do It, I don't see why having two slightly different forms for the same result is necessary. I thereby propose that the capitalized form be removed because:
i
,u
,f
) are lower case. Mandatinge
would make literals more consistent.This also makes the grammar slightly simpler. But really I just care about not having two trivially different ways of doing the same thing.
The text was updated successfully, but these errors were encountered: