Replace uses of reinterpret_cast with transmute, remove reinterpret_cast #5163
Comments
|
Using some of my bug janitor time to work on this. |
bors
added a commit
that referenced
this issue
Apr 20, 2013
As the name suggests this replaces many instances of cast::reinterpret_cast by cast::transmute. It's essentially the boring part of fixing #5163, the remaining reinterpret_casts should be more tricky to remove (unless I missed a boring case). r? @catamorphism
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
May 2, 2020
Change badge branch from master to auto For some reason GHA classifies the bors merges on the master branch as a push to the auto branch, even though the workflow got triggered by a push to the master branch. I guess this has something to do with the same commit hash on master+auto directly after the merge? changelog: none
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
May 2, 2020
…shearth,llogiq,flip1995 I like to move it, move it GHA now runs in the background for 6 days (rust-lang#5088) Since then ~~15~~ 19 PRs were successfully merged and Travis+Appveyor agreed on the status in every case. ([GitHub PR search query](https://github.com/rust-lang/rust-clippy/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+merged%3A%3E%3D2020-02-12T15%3A42%3A00+sort%3Aupdated-desc+NOT+%5Bgh-pages%5D+in%3Atitle)) Some PRs were: - rust-lang#5163 - rust-lang#5170 - rust-lang#5168 - rust-lang#5173 - rust-lang#5171 - rust-lang#5156 - rust-lang#4809 - rust-lang#5177 - rust-lang#5182 - rust-lang#5183 - rust-lang#5184 - rust-lang#5185 - rust-lang#5186 - rust-lang#5181 - rust-lang#5189 Bug with GHA: - When a rustc PR gets merged between the `integration_build` and the `integration` job, the `integration` job will fail. This happened once in rust-lang#5162, but not in the past 6 days. Even if it would happen every 4th PR we would save time, since splitting up the integration build and tests saves 5-7 minutes per run and a complete run takes 15-17 minutes - Sometimes the MacOS build takes up to an hour to download the master toolchain. Until now, this happend 2 or 3 times and can be resolved by a `@bors r3try`+canceling the previous run (restarting single jobs is not supported yet) ## Before merging this, rust-lang/rust-central-station#578 has to get merged This PR is for starting the discussion and to get consensus (@rust-lang/clippy) on a final move to GHA. If we're ready, I'll contact Pietro, to finalize the move. changelog: Clippy completely runs on GHA now 🎉 --- BTW: The deployment already runs on GHA, instead of Travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
reinterpret_castis rarely needed now, maybe never. Try to replace all uses withtransmute, then removereinterpret_cast.The text was updated successfully, but these errors were encountered: