Migrate to using cargo fix --edition-idioms
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DON'T MERGE YET! This PR is awaiting the stuff mentioned above to be merged into Cargo. |
|
Ah yes, sorry! This is blocked on rust-lang/cargo#5843 making its way into nightlies. |
|
Note to self: Once this is merged, #19 should be rendered moot so we can close that then. |
This'll be a new flag being added to Cargo to help transitioning to the idioms of the 2018 edition. At the same time this removes the `+nightly` invocations from Cargo commands, removes `--all-targets` as it's the default, and finally removes `--all-features` as the default of `--all-targets` should be enough.
cargo fix --idiomscargo fix --edition-idioms
|
Everything is now landed in rust-lang/rust and a nightly is one the way out, so merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This'll be a new flag being added to Cargo to help transitioning to the idioms
of the 2018 edition.
At the same time this removes the
+nightlyinvocations from Cargo commands,removes
--all-targetsas it's the default, and finally removes--all-featuresas the default of--all-targetsshould be enough.