-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a --edition-idioms
flag to cargo fix
#5843
Conversation
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
r? @killercup |
--idioms-for
flag to cargo fix
--idioms
flag to cargo fix
I've updated this to just have a |
Is there a missing commit? I only see Speaking only for myself, I much prefer the semantics of |
If the goal is to avoid needing to specify 2018 as an argument (as #5845 seems to suggest), perhaps |
5ce924f
to
9f341ae
Compare
Oops sorry forgot to push up the commits, and |
--idioms
flag to cargo fix
--edition-idioms
flag to cargo fix
@bors: r+ Ok I'm gonna go ahead and try to squeeze this in for the preview, but we can of course continue to iterate in-tree! |
9f341ae
to
2f8023e
Compare
This, like `--prepare-for`, will be part of the transition guide which automatically applies the necessary lint group from the compiler to associated code. The `--edition-idioms` flag does not take an argument and will automatically enable the right lint group based on the edition being compiled for. cc #52679
2f8023e
to
80f9d31
Compare
@bors: r+ |
📌 Commit 80f9d31 has been approved by |
Add a `--edition-idioms` flag to `cargo fix` This, like `--prepare-for`, will be part of the transition guide which automatically applies the necessary lint group from the compiler to associated code. cc rust-lang/rust#52679
☀️ Test successful - status-appveyor, status-travis |
This, like
--prepare-for
, will be part of the transition guide whichautomatically applies the necessary lint group from the compiler to associated
code.
cc rust-lang/rust#52679