Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project proposal for documenting and testing MSRV in all WG crates #443

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Add project proposal for documenting and testing MSRV in all WG crates #443

merged 1 commit into from
Apr 14, 2020

Conversation

adamgreig
Copy link
Member

@adamgreig adamgreig commented Apr 12, 2020 •
edited
Loading

As we discussed in the last meeting, I'm proposing a new project on making sure all our crates have a documented and tested MSRV. This would be an ideal project for newcomers to help out with, as the work to do is fairly well defined but has an immediately useful impact on our projects' stability.

(rendered)

For reference, here are the discussion points:

  • Do we want to also include a MSRV badge in repository READMEs? See rand for an example.
  • Do we want to update the WG policy to stable-2, i.e. #427?

@adamgreig adamgreig requested review from dylanmckay, jcsoo and a team as code owners April 12, 2020 21:01
@eldruin eldruin mentioned this pull request Apr 13, 2020
Merged
@thalesfragoso thalesfragoso mentioned this pull request Apr 14, 2020
Closed
jamesmunns
jamesmunns approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 14, 2020

Build succeeded:

@bors bors bot merged commit 645484a into master Apr 14, 2020
@bors bors bot deleted the project-msrv branch April 14, 2020 18:10
@adamgreig adamgreig mentioned this pull request Apr 14, 2020
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmunns jamesmunns jamesmunns approved these changes

@dylanmckay dylanmckay Awaiting requested review from dylanmckay

@jcsoo jcsoo Awaiting requested review from jcsoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamgreig @jamesmunns