Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSRV configuration to CI #198

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Add MSRV configuration to CI #198

merged 2 commits into from
Apr 13, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Apr 6, 2020

The compatibility with the MSRV should be checked by the CI. At the moment that is Rust 1.35.0 due to this issue.
The MSRV and its update process should probably also be documented in the README.

@eldruin eldruin requested review from ilya-epifanov, thejpster and a team as code owners April 6, 2020 20:00
@rust-highfive
Copy link

r? @ithinuel

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Review is incomplete T-hal labels Apr 6, 2020
@ryankurte
Copy link
Contributor

thanks for the PR! seems like a good addition to me, can we also add a note to the readme as per here?

@ryankurte ryankurte self-assigned this Apr 7, 2020
@eldruin
Copy link
Member Author

eldruin commented Apr 8, 2020

@ryankurte Sure. It is done now.
What do you think of a rustc compatibility badge (also a documentation badge and so on) like here?

@eldruin
Copy link
Member Author

eldruin commented Apr 13, 2020

Ok, badges will be discussed in rust-embedded/wg#443.
We can add that in a separate PR after the discussion has settled.
Is there anything else preventing the merge of this?

therealprof
therealprof approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 13, 2020

Build succeeded

@bors bors bot merged commit cad3b0c into rust-embedded:master Apr 13, 2020
@adamgreig adamgreig mentioned this pull request Apr 20, 2020
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

@ilya-epifanov ilya-epifanov Awaiting requested review from ilya-epifanov

@thejpster thejpster Awaiting requested review from thejpster

Assignees

@ryankurte ryankurte

@ithinuel ithinuel

Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eldruin @rust-highfive @ryankurte @therealprof @ithinuel