Make global-context-less-secure actually enable the global context (fixup for #407) #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #407 we restored the
global-context-less-secure
feature, but it didn't actually do anything because #385 changed all the cfg checks on the whole module to depend onglobal-context
, so we need to enableglobal-context
in order to make that module compile.so before all this, users could enable just
global-context-less-secure
without enabling theglobal-context
, and after this PR it will behave the same.(this will not enable the randomization because of:
rust-secp256k1/src/context.rs
Line 51 in 1cf2429