Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make global-context-less-secure actually enable the global context (fixup for #407) #431

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

elichai
Copy link
Member

@elichai elichai commented Mar 28, 2022

In #407 we restored the global-context-less-secure feature, but it didn't actually do anything because #385 changed all the cfg checks on the whole module to depend on global-context, so we need to enable global-context in order to make that module compile.

so before all this, users could enable just global-context-less-secure without enabling the global-context, and after this PR it will behave the same.

(this will not enable the randomization because of:

#[cfg(all(feature = "rand-std", not(feature = "global-context-less-secure")))]
)

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c1bb316

Good catch.

@apoelstra apoelstra merged commit ae985dd into rust-bitcoin:master Mar 28, 2022
@elichai elichai deleted the fix-unsecure-global-ctx branch March 28, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants