Skip to content

Commit

Permalink
Merge #431: Make global-context-less-secure actually enable the globa…
Browse files Browse the repository at this point in the history
…l context (fixup for #407)

c1bb316 Make global-context-less-secure actually enable the global context (Elichai Turkel)

Pull request description:

  In #407 we restored the `global-context-less-secure` feature, but it didn't actually do anything because #385 changed all the cfg checks on the whole module to depend on `global-context`, so we need to enable `global-context` in order to make that module compile.

  so before all this, users could enable *just* `global-context-less-secure` without enabling the `global-context`, and after this PR it will behave the same.

  (this will not enable the randomization because of: https://github.com/rust-bitcoin/rust-secp256k1/blob/1cf2429b12ff06a04a5c882f2f5d918042629660/src/context.rs#L51)

ACKs for top commit:
  apoelstra:
    ACK c1bb316

Tree-SHA512: edc7b4916b359a0696cc25f498bc52ad340f981ad6b01b83b68966d6179200bac6acb96f5480157e24c605b5552bdd7b6eb8770bc9a2c5734da3df11c021fb5b
  • Loading branch information
apoelstra committed Mar 28, 2022
2 parents 1cf2429 + c1bb316 commit ae985dd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ global-context = ["std"]
# (If you are sure the `rand-std` feature will not be enabled, e.g.
# if you are doing a no-std build, then this feature does nothing
# and is not necessary.)
global-context-less-secure = []
global-context-less-secure = ["global-context"]

[dependencies]
secp256k1-sys = { version = "0.5.0", default-features = false, path = "./secp256k1-sys" }
Expand Down

0 comments on commit ae985dd

Please sign in to comment.