updates #12
Merged
updates #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orgicus
suggested changes
Feb 25, 2020
| @@ -53,7 +53,7 @@ void setup() { | |||
| // disable automatic polling: request data manually when a new frame is ready | |||
| runway.setAutoUpdate(false); | |||
| // setup camera | |||
| camera = new Capture(this,640,480); | |||
| camera = new Capture(this, 640, 480); | |||
There was a problem hiding this comment.
the spaces are great: makes the code easier to read
| float y = box.getFloat(1); | ||
| float w = box.getFloat(2); | ||
| float h = box.getFloat(3); | ||
| for (int i = 0; i < data.size(); i++) { |
There was a problem hiding this comment.
JSON update in the DenseCap example is great
examples/HTTP/GPT2/GPT2_012.pde
Outdated
| @@ -107,5 +107,5 @@ void runwayDataEvent(JSONObject runwayData){ | |||
| // point the sketch data to the Runway incoming data | |||
| data = runwayData; | |||
| //get the value of the "text" key | |||
| text_output = data.getString("text"); | |||
| text_output = data.getString("generated_text"); | |||
There was a problem hiding this comment.
JSON update in the GPT example is great
| text(className + " score: " + String.format("%.2f",score),x,y); | ||
| text(label + " score: " + String.format("%.2f", val), x, y); | ||
|
|
||
| //console logs |
There was a problem hiding this comment.
are these console logs still needed ?
(if not, please remove)
examples/HTTP/GPT2/GPT2_012.pde
Outdated
| @@ -107,5 +107,5 @@ void runwayDataEvent(JSONObject runwayData){ | |||
| // point the sketch data to the Runway incoming data | |||
There was a problem hiding this comment.
Last remarks:
- please remove the .DS_Store file (I should've added that to a .gitignore, my bad)
- have the sketches changed names ? (e.g. GPT2.pde -> GPT2_012.pde / DenseCap.pde -> DenseCap_012.pde ?) if so, can they be renamed without the _012 suffix ?
Thank you so much for the contribution and apologies for the late reponse.
I will have another look after you commit the changes and merge 🙌
|
No problem, I'll get these changes made! |
small changes made
|
Changes made. :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON data structure updates