Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPT2 example #11

Closed
j3nsykes opened this issue Feb 19, 2020 · 6 comments
Closed

GPT2 example #11

j3nsykes opened this issue Feb 19, 2020 · 6 comments

Comments

@j3nsykes
Copy link
Contributor

Is more recent updates Runway has changed the output text data.getString() to be "generated_text" not "text". This makes the Processing example work on versions around 0.10.10.
However, in the more recent versions 0.10.27 this example fails to generate the output text in either Runway or Processing. It receives the input String fine which makes me think it isn't a port or network issue. Perhaps another message structure was changed that is not visible in the code but part of the library file?
Other examples continue to work such as AttGAN.

@orgicus
Copy link
Contributor

orgicus commented Feb 19, 2020

Thanks for pointing that out,

Indeed it looks like the json structure for the model changed a bit.

I'll need to do a pass of testing examples and updating them accordingly

@cvalenzuela
Copy link
Member

We identified a bug in 0.10.27 that was causing an issue with the way data was proceeded when using the Networks panel. We are patching the bug and will update the fix in 0.10.28

@j3nsykes
Copy link
Contributor Author

Amazing thank you!

@cvalenzuela
Copy link
Member

This is now fixed on 0.10.28! @j3nsykes try updating your version of Runway.

Also, you might need to update the output to:

 text_output = data.getString("generated_text");

Let me know if that works

@j3nsykes
Copy link
Contributor Author

That works great now thanks!

@orgicus
Copy link
Contributor

orgicus commented Feb 25, 2020

Closing this issue as it's been resolved by @j3nsykes in PR #12

@orgicus orgicus closed this as completed Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants