-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for headless=new #379
Conversation
Anything we can do to help get this implemented @route? |
@lifesaverluke not that I can think of, I'm on it but I was sick and on the road. |
It looks like even though I can be able to land support with frames, there's at least one quite major regression for Chrome which shows duplicated requests and there's an event missing which is quite crucial for network. So it's not gonna happen until they fix it. |
A thing that changed for sure is that Maybe we just need to adjust the tests? |
No it’s not that simple, networking is broken |
Bit weird that puppeteer / playwright etc do work with headless=new? What's the difference? |
@lifesaverluke in general it works, but there are a lot of tests broken for networking. The design is different, the architecture is also different. But looks like I found solution to make it work In general the issue is with frames only https://www.chromium.org/developers/design-documents/oop-iframes/ |
Since "new" mode has a bug with file download behavior it's not default now, but you can turn on "new" mode if it satisfies your needs. |
@route Awesome! 😄 Will there be a new release later, with this included? |
released |
@route I appreciate the addition! Could we also get a new release of Cuprite? 🙏🏻 The current version locks Ferrum to |
@janko yep I was going to do that, but need to do some stuff offline ;) life is life) |
@route Of course, as a fellow open source maintainer, I totally understand 😉 I really appreciate all the work you did on Ferrum/Cuprite, it brought us tremendous benefits in my current company 🙌🏻 I decided we needed the new headless mode when I encountered a system test that was failing in old headless mode and passing in headful mode. We were able to use the new headless mode with current Cuprite by passing |
@janko Very good article btw! |
Addresses #352