Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --headless=new Chrome flag #352

Closed
singhprd opened this issue Apr 12, 2023 · 9 comments
Closed

Use --headless=new Chrome flag #352

singhprd opened this issue Apr 12, 2023 · 9 comments

Comments

@singhprd
Copy link

singhprd commented Apr 12, 2023

Hello!

I have just read this: https://developer.chrome.com/articles/new-headless/

TLDR:

Chrome headless was released in 2017, and was technically a separate, alternate browser implementation that happened to be shipped as part of the same Chrome binary.

The Chrome team are unifying Headless and headful modes

To use the new mode start chrome with --headless=new

Currently, passing the --headless command-line flag without an explicit value still activates the old Headless mode — Chrome plan to change this default to new Headless over time.

I was wondering about starting a discussion here - should Ferrum default to setting --headless=new?

There might be more to do that just update the option here so it'd be great to hear thoughts?:
https://github.com/rubycdp/ferrum/blob/main/lib/ferrum/browser/options/chrome.rb#L8

Proof of concept update from my fork here:
https://github.com/fac/ferrum/pull/8/files

@route
Copy link
Member

route commented Apr 13, 2023

Yep, I was looking at this flag for a while, and I think it's good idea to turn it on by default instead of headless=true

@JacobEvelyn
Copy link

Any chance we can get this PR merged and released in a new version soon?

@route
Copy link
Member

route commented Jun 27, 2023

@JacobEvelyn I don't see any PR

@JacobEvelyn
Copy link

Oh sorry; I thought @singhprd's draft PR linked above was in this repo instead of a fork. @singhprd do you want to turn it into a PR here? @route @singhprd would it be helpful if I did?

@route
Copy link
Member

route commented Jul 15, 2023

@JacobEvelyn don't ask, do if you can ;) Apparently it's not that easy as turn on new mode, as there are a lot of failing tests.

@route
Copy link
Member

route commented Jul 16, 2023

As I can see it's not that easy as new Chrome works differently with frames, but I started to work on this.

@jtoy
Copy link

jtoy commented Aug 11, 2023

is it merged?

@route
Copy link
Member

route commented Aug 12, 2023

There’s nothing to merge yet

@route
Copy link
Member

route commented Sep 11, 2023

I'm closing this issue as there's a PR you can follow it.

@route route closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants