Make sure models array has unique list of models #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes from previous calls and affects performance severly)
|
This is great. Needs a CHANGELOG entry please. I wonder if despite the fact that this is mostly internal there's a possible spec here, too. |
|
Added CHANGELOG. This is indeed internal and I don't think it needs another spec. Previous implementation just piled up many duplicated models on the array, now it's without dups. |
|
I squashed and merged this via tim-vandecasteele@cdd877b. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it piles up duplicates from previous calls and affects performance severely.
Fixes #161.