Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering is super slow because of models_with_included_presenters #161

Closed
elado opened this issue Oct 31, 2014 · 1 comment
Closed

Rendering is super slow because of models_with_included_presenters #161

elado opened this issue Oct 31, 2014 · 1 comment

Comments

@elado
Copy link
Contributor

elado commented Oct 31, 2014

Rendering became extremely slow for me. Debugging it led to models_with_included_presenters which every call gets all the models from last call plus more models for the current endpoint, regardless if the models were on the array or not.
The array should hold only unique models without dups.

Rendering time was 360 seconds for about 80 endpoints.

PR coming.
This was referenced Oct 31, 2014
Closed
Open
@dblock
Copy link
Member

dblock commented Dec 14, 2014

I believe this is mostly fixed by #162. Closing. Reopen if I am wrong.

@dblock dblock closed this as completed Dec 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure models array has unique list of models elado/grape-swagger
2 participants
@elado @dblock