Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardware_interfaceのパラメータをxacro引数から変更する #35

Merged
merged 6 commits into from
Jun 3, 2022

Conversation

Kuwamai
Copy link
Contributor

@Kuwamai Kuwamai commented Jun 2, 2022

What does this implement/fix?

hardware_interfaceのパラメータをxacro引数から変更できるようにしました。

Does this close any currently open issues?

#34 をクローズします

How has this been tested?

下記コマンドを実行して使用するUSBポートの指定ができることを確認しました。

$ ros2 launch crane_plus_examples demo.launch.py port_name:=/dev/ttyUSB0

Any other comments?

ないです

Checklists

@Kuwamai Kuwamai added the Type: Feature New Feature label Jun 2, 2022
@Kuwamai Kuwamai requested a review from ShotaAk June 2, 2022 06:10
Copy link

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRANE+V2実機で動作確認しました。

USBのポートや、その他のパラメータが機能することを確認しています。

コメントを残したので対応お願いします。

crane_plus_control/README.md Outdated Show resolved Hide resolved
crane_plus_control/README.md Outdated Show resolved Hide resolved
@Kuwamai Kuwamai requested a review from ShotaAk June 3, 2022 05:28
Copy link

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShotaAk ShotaAk merged commit e2f9c14 into master Jun 3, 2022
@ShotaAk ShotaAk deleted the add_ros2_control_args branch June 3, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants