-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use DDS standard API #518
Merged
clalancette
merged 60 commits into
ros2:master
from
eProsima:feature/dds-api-refactor-rebased
Apr 6, 2021
Merged
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
360fb1c
Revert "Unique network flows (#502)"
MiguelCompany 7e86405
rebase first steps
3e14ccf
rebase second steps
d44ea5f
rebase third steps, compiling
780780d
uncrustify
bd69cbc
rmw fastrtps clean state
0da237b
fix bugs in client, participant and take
0ecc209
fix cpplint and uncrustify
f532601
construct Lonable Sequence to avoid heap allocations
d7cac45
uncrustify
abff9e4
Use valid_data instead of instance_state.
MiguelCompany 13918dc
Fix build with security enabled.
MiguelCompany 290836c
Solve link problems on Windows.
MiguelCompany 50b5357
Restore old rmw_take_sequence code.
MiguelCompany 80307e7
Fixed warning.
MiguelCompany 429b981
Added more topic related methods to utils.
MiguelCompany 932ce83
Mutex renamed.
MiguelCompany 1ddb9d7
Publisher types changed.
MiguelCompany befb40d
Subscription types changed.
MiguelCompany fb5bb55
Cilent types changed.
MiguelCompany a634cd3
Service types changed.
MiguelCompany 6beea1f
Removed create_topic_rmw
MiguelCompany 179679b
Removed topics_list_
MiguelCompany 972775f
Linters
MiguelCompany 5d2b138
Addressed internal review comments
MiguelCompany db3a1ab
Addressed internal review comments
MiguelCompany 41afcf3
Linters
MiguelCompany 36c04d1
Addressed internal review comments
MiguelCompany f634b96
Addressed internal review comments
MiguelCompany 9a0382c
Improvements on destroy_participant.
MiguelCompany 5c75031
Correctly cleanup when deleting participant.
MiguelCompany 9e7c92f
Linters
MiguelCompany a3bfff8
Fixed duration conversions on rtps_qos_to_rmw_qos
MiguelCompany 4d9c19c
Added test for dds_qos_to_rmw_qos
MiguelCompany 9cefd7e
Improvements on destroy_client
MiguelCompany 6e1c82f
Improvements on destroy_service
MiguelCompany f6dd571
Linters
MiguelCompany 732d814
Avoid API break on native getters.
MiguelCompany c2f6899
Removed old native getters API.
MiguelCompany 7ad1f99
Use pointers on output arguments.
MiguelCompany c7a5149
Flip operands on equal comparisons.
MiguelCompany 30a462b
Apply suggestions on destroy_service and destroy_client.
MiguelCompany 0c988c7
Added topic holder utility.
MiguelCompany 745e152
Apply suggestions on publisher creation.
MiguelCompany 7898d5e
Apply suggestions on subscription creation.
MiguelCompany f1d4621
Apply suggestions on client creation.
MiguelCompany 7ed04a1
Apply suggestions on service creation.
MiguelCompany 940ac4a
Linters
MiguelCompany 88d6ac0
Using auto where possible.
MiguelCompany f4e24ec
Documentation on utils.hpp
MiguelCompany 87b2371
Linters
MiguelCompany 6ac968a
Fixed some basic review comments.
MiguelCompany 1e8f025
Removed redundant initialization of listeners.
MiguelCompany 2f82295
Fixed doxygen
MiguelCompany 5823fd3
Use snake_case variable names.
MiguelCompany 7a2a52a
Reduced cleanup lambdas.
MiguelCompany 28b3b0f
Apply suggestions on destroy_participant.
MiguelCompany fd6fe5d
Apply suggestions on destroy_publisher and destroy_subscription.
MiguelCompany e0b0b01
Unique network flows (#502)
MiguelCompany 2f4e0cc
Fix segfault on cleanup lambda
MiguelCompany File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Addressed internal review comments
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
- Loading branch information
commit 36c04d1682e13f1f0345ee50380b07d2001df68a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,6 +65,8 @@ create_subscription( | |
bool keyed, | ||
bool create_subscription_listener) | ||
{ | ||
RCUTILS_CAN_RETURN_WITH_ERROR_OF(nullptr); | ||
|
||
///// | ||
// Check input parameters | ||
RMW_CHECK_ARGUMENT_FOR_NULL(participant_info, nullptr); | ||
|
@@ -150,13 +152,13 @@ create_subscription( | |
fastdds_type)) | ||
{ | ||
RMW_SET_ERROR_MSG_WITH_FORMAT_STRING( | ||
"create_publisher() called with existing topic name %s with incompatible type %s", | ||
"create_subscription() called with existing topic name %s with incompatible type %s", | ||
topic_name_mangled.c_str(), type_name.c_str()); | ||
return nullptr; | ||
} | ||
|
||
///// | ||
// Create the RMW Subscriber struct (info) | ||
// Create the custom Subscriber struct (info) | ||
CustomSubscriberInfo * info = nullptr; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @MiguelCompany nit: consider declaring and initializing on the same line. |
||
|
||
info = new (std::nothrow) CustomSubscriberInfo(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MiguelCompany nit^2: collapse the last two lines in one.