Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Remove rmw_connext dead code #258

Closed
wants to merge 1 commit into from
Closed

Remove rmw_connext dead code #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions rmw_connext_cpp/src/rmw_publisher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,7 @@ rmw_create_publisher(
DDS_String_free(topic_str);
topic_str = nullptr;
}
if (publisher) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary of the goto in this line is triggered: https://github.com/ros2/rmw_connext/pull/258/files#diff-3bcd912088bec36df10ef09cd4c564b1R220

rmw_publisher_free(publisher);
}

// Assumption: participant is valid.
if (dds_publisher) {
if (topic_writer) {
Expand Down
4 changes: 1 addition & 3 deletions rmw_connext_cpp/src/rmw_subscription.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,9 +250,7 @@ rmw_create_subscription(
DDS_String_free(topic_str);
topic_str = nullptr;
}
if (subscription) {
rmw_subscription_free(subscription);
}

// Assumption: participant is valid.
if (dds_subscriber) {
if (topic_reader) {
Expand Down