This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Remove rmw_connext dead code #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dead code in API rmw_create_subscription()
the condition "subscription" cannot be true in the "fail"
clauses and the execution never reaches this statement:
if (subscription) {
rmw_subscription_free(subscription);
}
the "subscribtion" will be finally free by
rmw_destroy_subscription() when it's not a nullptr
Dead code in API rmw_create_publisher()
the condition "publisher" cannot be true in the "fail"
clauses, so the execution cannot reach this statement:
if (publisher) {
rmw_publisher_free(publisher);
}
the "publisher" will be finally free by
rmw_destroy_publisher() when it's not a nullptr
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
|
I may miss something here, but I think this PR is not correct. Opposite to your PR in [0] https://github.com/ros2/rmw_connext/blob/master/rmw_connext_cpp/src/rmw_publisher.cpp#L102 |
dirk-thomas
reviewed
Oct 23, 2017
| @@ -252,9 +252,7 @@ rmw_create_publisher( | |||
| DDS_String_free(topic_str); | |||
| topic_str = nullptr; | |||
| } | |||
| if (publisher) { | |||
There was a problem hiding this comment.
This is necessary of the goto in this line is triggered: https://github.com/ros2/rmw_connext/pull/258/files#diff-3bcd912088bec36df10ef09cd4c564b1R220
|
@Karsten1987 @dirk-thomas yes, you're correct and I missed that, thanks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dead code in API
rmw_create_subscription()the condition "
subscription" cannot be true in the "fail"clauses and the execution never reaches this statement:
the "
subscribtion" will be finally free byrmw_destroy_subscription()when it's not a nullptrDead code in API
rmw_create_publisher()the condition "
publisher" cannot be true in the "fail"clauses, so the execution cannot reach this statement:
the "
publisher" will be finally free byrmw_destroy_publisher()when it's not a nullptrSigned-off-by: Ethan Gao ethan.gao@linux.intel.com