Fix cpplint build/include_order errors #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
clalancette
requested changes
Jul 24, 2024
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
|
This change heavily reduced the warnings; in 62 we had 2 CMake warnings, 30 gcc warnings, 2 clang-tidy warnings, and 38 test failures. After this PR, in 63, we had 2 CMake warnings, 30 gcc warnings, 2 clang-tidy warnings, and 0 test failures. So this looks like a success. I'm going to go ahead and merge it. |
This was referenced Aug 8, 2024
Blast545
added a commit
to Blast545/performance_test
that referenced
this pull request
Aug 9, 2024
* Fix cpplint build/include_order errors * Fix uncrustify parenthesis Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Blast545
added a commit
to Blast545/performance_test
that referenced
this pull request
Aug 9, 2024
* Fix cpplint build/include_order errors * Fix uncrustify parenthesis Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
clalancette
pushed a commit
that referenced
this pull request
Aug 20, 2024
clalancette
pushed a commit
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address linter warnings on: https://build.ros2.org/view/Rci/job/Rci__nightly-performance_ubuntu_noble_amd64/61/consoleFull#console-section-43
@Crola1702 Can you run CI on this one to verify? 🙏 You can use this job that Chris launched as reference: #38 (comment)