Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👩‍🌾 uncrustify regression on connext_dds_micro_communicator test for all distros #49

Closed
claraberendsen opened this issue Jul 22, 2024 · 2 comments
Assignees

Comments

@claraberendsen
Copy link

Description

There seems to be a test regression on all distros for the test connext_dds_micro_communicator

The error is

--- src/communication_abstractions/connext_dds_micro_communicator.hpp
+++ src/communication_abstractions/connext_dds_micro_communicator.hpp.uncrustify
@@ -295 +295,2 @@
-  static auto init_data(T & data)->decltype (data.header_.frame_id_, void ()) {
+  static auto init_data(T & data)->decltype (data.header_.frame_id_, void ())
+  {
@@ -317 +318,2 @@
-  static auto init_fields(T & data)->decltype (data.fields_, void ()) {
+  static auto init_fields(T & data)->decltype (data.fields_, void ())
+  {

Affected builds

Additional information

File
https://github.com/ros2/performance_test/blob/7081dd3fae9d1bfe985a94858b6c96650fd1bb4b/performance_test/src/communication_abstractions/connext_dds_micro_communicator.hpp

@Blast545
Copy link

Blast545 commented Aug 8, 2024

I fixed this on main with: #53, feel free to close it whenever you want, as I will be tracking the backports with #48, which is technically the same issue.

@clalancette
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants