Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install cmake version config file #17

Merged
merged 3 commits into from
Oct 11, 2015
Merged

Install cmake version config file #17

merged 3 commits into from
Oct 11, 2015

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters commented Oct 2, 2015

I will wait until #7 is merged.

I plan to do something similar to the following:

@scpeters
Install cmake version config file
cc192e1 
Uses SameMajorVersion matching criteria
@scpeters
Bump minor version to 0.4
2b0edce 
So that new pointer typedefs can be found
@scpeters
Copy link
Contributor Author

scpeters commented Oct 2, 2015

This creates and installs a cmake version config file. I've also bumped the minor version so downstream code will be able to find headers with the new pointer typedefs.

@isucan
Copy link
Contributor

isucan commented Oct 2, 2015

we should bump the version in the urdfdom pkg as well

@isucan
Copy link
Contributor

isucan commented Oct 2, 2015

I don't have an easy means to test this -- can someone test?

@scpeters
Copy link
Contributor Author

scpeters commented Oct 2, 2015

I was planning to make another pull request to urdfdom that will explicitly require urdfdom_headers 0.4 so it can use the new pointer typedefs. I could bump the version in that pull request.

@scpeters
Copy link
Contributor Author

scpeters commented Oct 2, 2015

I'll go and make that urdfdom pull request so this one will be easier to test.

@scpeters scpeters mentioned this pull request Oct 2, 2015
Merged
@scpeters
Copy link
Contributor Author

scpeters commented Oct 2, 2015

ros/urdfdom#65

@scpeters
Fix missing include in urdf_model/types.h
d55c892 
Include boost/pointer_cast.hpp since we
are using the pointer_cast functions.
Fixes ros#66.
@scpeters
Copy link
Contributor Author

scpeters commented Oct 9, 2015

I added a fix for ros/urdfdom#66 as well (missing include file)

@scpeters scpeters mentioned this pull request Oct 9, 2015
Closed
isucan added a commit that referenced this pull request Oct 11, 2015
@isucan
Merge pull request #17 from scpeters/cmake_version_file
eb2e40d 
Install cmake version config file
@isucan isucan merged commit eb2e40d into ros:master Oct 11, 2015
@scpeters scpeters deleted the cmake_version_file branch October 12, 2015 04:06
@scpeters scpeters mentioned this pull request Oct 13, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @isucan