Include underlay source folder in rosdep path #2025
Conversation
As OMPL isn't yet registering properly with the ament index for ros2 and searching all of << parameters.underlay >>/install will stall rosdep when searching entire $ROS_WS/install folder
| dependencies=$( | ||
| rosdep install -q -y \ | ||
| --from-paths src \ | ||
| $underlay_ws \ |
There was a problem hiding this comment.
To make sure I understand this, this is saying if we're in the overlay workspace, include the underlay workspace in the rosdep install command? Is that because when it runs with both sources, it combines them and views this as within the same list?
There was a problem hiding this comment.
Yep. The --from-paths is to specify a list of paths to recursively search for package.xml files. With pwd being the overlay workspace, we just add the absolute path to the underlay source folder to ensure we find any packages that are missing from the ament index we sourced:
This patch isn't very formulaic, as it can't really recursively scale, e.g. if a package fails to install itself correctly in your underlay's underlay, your SOL; vs. ament index that recursively daisy chains for us.
Recursively searching paths in python is also slow, and seems to stall on the ros install folder.
Codecov Report
@@ Coverage Diff @@
## main #2025 +/- ##
=======================================
Coverage ? 85.01%
=======================================
Files ? 294
Lines ? 15011
Branches ? 0
=======================================
Hits ? 12762
Misses ? 2249
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Now that ompl/ompl#753 is fixed This reverts commit 13c878b.
now that ompl issue is resolved ompl/ompl#753
now that ompl issue is resolved ompl/ompl#753
now that ompl issue is resolved ompl/ompl#753
now that ompl issue is resolved ompl/ompl#753
* Revert to testing image for CI * Use ompl from testing repo and modify Dockerfile to account for empty underlay * Clean up RUN directive for caching * Revert #2025 now that ompl issue is resolved ompl/ompl#753 * Continue checkout if ccache doesn't yet exist
As OMPL isn't yet registering properly with the ament index for ros2 and searching all of << parameters.underlay >>/install will stall rosdep when searching entire $ROS_WS/install folder
* Revert to testing image for CI * Use ompl from testing repo and modify Dockerfile to account for empty underlay * Clean up RUN directive for caching * Revert ros-navigation#2025 now that ompl issue is resolved ompl/ompl#753 * Continue checkout if ccache doesn't yet exist
As OMPL isn't yet registering properly with the ament index for ros2
and searching all of << parameters.underlay >>/install will stall rosdep
when searching entire $ROS_WS/install folder
Related: #2021 (comment)