Skip ros_ign_gazebo on platforms not yet supported #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
sloretz
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
LGTM - I double checked the edited yaml matches the failing builds.
release-buster-build.yamlhttp://build.ros.org/job/Nbin_db_dB64__ros_ign_gazebo__debian_buster_amd64__binary/release-armhf-build.yamlhttp://build.ros.org/job/Nbin_ufhf_uFhf__ros_ign_gazebo__ubuntu_focal_armhf__binary/release-arm64-build.yamlhttp://build.ros.org/job/Nbin_ufv8_uFv8__ros_ign_gazebo__ubuntu_focal_arm64__binary/release-buster-arm64-build.yamlhttp://build.ros.org/job/Nbin_dbv8_dBv8__ros_ign_gazebo__debian_buster_arm64__binary/
|
Not sure about the process on this repository, is this ready to be merged? |
Yup! I assumed the process was author-squash-merge. |
nuclearsandwich
referenced
this pull request
in ros2/ros_buildfarm_config
Dec 28, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're missing
ignition-gazebo3on some platforms, see gazebosim/gz-sim#319.