improve CMake regex to detect messages without filename:linenumber #169
Conversation
| @@ -3,17 +3,23 @@ | |||
| <groovyParsers> | |||
| <hudson.plugins.warnings.GroovyParser> | |||
| <name>CMake</name> | |||
| <regexp>^CMake (Deprecation Warning|Warning|Warning \(dev\)|Error) at (.+):(\d+)( \((.+)\))?:\n( .+\n)?(.+\n( .+\n)*)?</regexp> | |||
| <regexp>^CMake (Deprecation Warning|Warning|Warning \(dev\)|Error)( at (.+):(\d+)( \((.+)\))?)?:\n(?! Manually-specified variables were not used by the project:)( .+\n)?(.+\n( .+\n)*)?</regexp> | |||
There was a problem hiding this comment.
We should consider updating the regexp to use named capture groups in a follow-up pull request to avoid the index shuffling below.
|
This change will need to be manually propagated to buildfarm master hosts since re-running puppet on them is not safe (#160). |
|
@dirk-thomas am I correct in thinking we want to deploy this on build.ros.org and build.ros2.org as well? |
A bunch of dev jobs may become unstable with that change, should we notify ROS maintainers before deploying ? Is any part of the infrastructure using this branch or can it be safely deleted? |
Yes.
I wouldn't announce it specifically. We announced it for Kinetic. That the regex missed some is a fix which I would say is fine to deploy. |
|
@nuclearsandwich What is the timeline to deploy this change? |
If there's team consensus that it doesn't need an announcement, I'll deploy it this morning. |
|
fine by me 👍 |
|
Updated on build.ros2.org and build.ros.org. |
Addresses ros2/build_farmer#73.
The following messages are being ignored since we currently pass some CMake variables to all packages even though they are only expected by some packages:
The change has already been deployed on ci.ros2.org.