Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

detect CMake warnings without a filename:linenumber #73

Closed
mikaelarguedas opened this issue Dec 3, 2017 · 4 comments
Closed

detect CMake warnings without a filename:linenumber #73

mikaelarguedas opened this issue Dec 3, 2017 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@mikaelarguedas
Copy link
Member

Right now we don't get all cmake warnings reported on CI.
Sometimes it's convenient (e.g. "Manually-specified variables were not used by the project:" as we pass the same cmake args to all packages).
But sometimes it's warnings we should address:

This is not defined behavior unless XXX is set to NEW.  For
compatibility with older versions of CMake, the previous undefined behavior
will be used.
@mikaelarguedas mikaelarguedas changed the title Jenkins plugin: find out how to get CMake no-dev warnings reported Jenkins plugin: find out how to get CMake dev warnings reported Dec 3, 2017
@nuclearsandwich
Copy link
Member

CMake warnings are parsed via an in-house regexp and script using the Jenkins Warnings parser plugin. Search for "Compiler warnings" on http://ci.ros2.org/configure (link requires authorization) for the regexp and the script to handle them. The one in CI is based on the one ROS buildfarm uses and may be identical currently. Because there is no config management for CI, we don't have any external versioning on the warnings config beyond the Jenkins config history so exercise caution when experimenting. You may want to add a CMake - Testing parser and change a ci config to use that instead in order to refine without affecting other jobs.

@mikaelarguedas
Copy link
Member Author

Thanks for the information!
I won't work on this before the release but all this is very valuable information for the person that'll look into this issue in the future.

@dirk-thomas dirk-thomas changed the title Jenkins plugin: find out how to get CMake dev warnings reported detect CMake warnings without a filename:linenumber Jan 3, 2018
@dirk-thomas
Copy link
Member

The currently used regular expression is only matching CMake messages which do have a filename:linenumber. Therefore I updated the title accordingly.

This should be addressed by ros-infrastructure/buildfarm_deployment#169 which has been deployed on ci.ros2.org.

@dirk-thomas dirk-thomas self-assigned this Jan 3, 2018
@dirk-thomas
Copy link
Member

dirk-thomas commented Jan 3, 2018

I created two follow up PR to address some warnings which appeared in the CI builds:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants