Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding JointGroupVelocityControllers #224

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Adding JointGroupVelocityControllers #224

merged 2 commits into from
Nov 1, 2018

Conversation

AndyZe
Copy link

@AndyZe AndyZe commented Oct 30, 2018

No description provided.

@AndyZe
Copy link
Author

AndyZe commented Oct 30, 2018

issue #218

miguelprada
miguelprada suggested changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@miguelprada miguelprada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comment about the MoveIt config, you should also add an exec_depend on velocity_controllers.

gavanderhoorn
gavanderhoorn approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the joint_speed topic (still) missing, this is an ok alternative for ros_control based setups.

@gavanderhoorn gavanderhoorn merged commit fb9dba2 into ros-industrial-attic:kinetic-devel Nov 1, 2018
@gavanderhoorn gavanderhoorn mentioned this pull request Nov 1, 2018
Closed
@AndyZe AndyZe mentioned this pull request Nov 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelprada miguelprada miguelprada requested changes

@gavanderhoorn gavanderhoorn gavanderhoorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndyZe @miguelprada @gavanderhoorn